Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BYD-CAN.cpp CAN values are decoded as little endian but should be big endian #612

Closed
jsphuebner opened this issue Nov 13, 2024 · 1 comment
Closed

BYD-CAN.cpp CAN values are decoded as little endian but should be big endian #612

jsphuebner opened this issue Nov 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jsphuebner
Copy link

Battery-Emulator/Software/src/inverter/BYD-CAN.cpp

Line 180 in 0b96665

inverter_voltage = ((rx_frame.data.u8[1] << 8) | rx_frame.data.u8[0]) * 0.1;

Values are decoded as LE but are BE

Those are boring values (just what you sent above) so probably no one ever used them
@dalathegreat dalathegreat mentioned this issue Nov 13, 2024
Merged
@dalathegreat
Copy link
Owner

Thanks @jsphuebner , fix is up in PR #613

@dalathegreat dalathegreat added the bug Something isn't working label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsphuebner @dalathegreat