-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rethink pre-compiled libController submodule #482
Comments
This is a very tough problem to solve. There are two points to consider:
|
Another solution could be to replace the |
The |
This is also an option. But isn't there a way to specify which files of the sub-module we want to distribute? In this case we could keep only files needed to build the libController, as well as other useful libraries. This would decrease a lot the size of the included files. |
Unfortunately, I don't think it is possible. |
I am closing this issue, as we resolved the problem in #508. The libcontroller sources are now directly commited on this repository and updated with a workflow every night if changes occured in the Webots repository. |
Robot windows and other dynamic libraries can't be used with WSL (WSL compatibility introduced in #481), because the
libController
is executed on Linux, while the requested libraries are distributed with Webots (running on Windows in this case). This implies that such libraries should be distributed with thewebots_ros2
package, or at least in the pre-compiled libController repository.Moreover, the current libController repository is containing binaries, which is not a very clean solution.
Here are some discussed solutions:
libController
and other useful libraries. These could be distributed with classic Webots nightly-builds as tarballs for example.webots_ros2
could download this package to replace thelibController
sub-module.webots_ros2
package. Nightly builds could be used for more up-to-date versions of libraries.The text was updated successfully, but these errors were encountered: