From 6da0bf4b2ff884596671af6aededfb9a2a34050f Mon Sep 17 00:00:00 2001 From: Luciano Frizzera Date: Wed, 8 Jul 2020 21:50:44 -0400 Subject: [PATCH] fix(message): only call callbacks if exists --- src/js/dialogs/message.js | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/js/dialogs/message.js b/src/js/dialogs/message.js index eab2b72f..7cb10a74 100644 --- a/src/js/dialogs/message.js +++ b/src/js/dialogs/message.js @@ -81,7 +81,7 @@ function Message(writer, parentEl) { var value = w.dialogManager.getDialogPref(config.showConfirmKey); if (value === false) { // user has disabled this confirm so just do the callback - config.callback(true); + if (config.callback) config.callback(true); return; } } @@ -106,11 +106,9 @@ function Message(writer, parentEl) { w.dialogManager.setDialogPref(config.showConfirmKey, value); } $message.dialog('close'); - // make sure dialog closes before callback - setTimeout(function() { - callback(true); - }, 0); + if (callback) setTimeout(() => callback(true), 0); // make sure dialog closes before callback }, + }, },{ text: noText, role: 'no', @@ -120,12 +118,9 @@ function Message(writer, parentEl) { w.dialogManager.setDialogPref(config.showConfirmKey, value); } $message.dialog('close'); - // make sure dialog closes before callback - setTimeout(function() { - callback(false); - }, 0); - } - } + if (callback) setTimeout(() => callback(false), 0); // make sure dialog closes before callback + }, + }, ]); $message.dialog('open'); },