Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: Configure dedicated azurerm_route and remove inline Route config from azurerm_route_table #9

Closed
ytsarev opened this issue Sep 29, 2022 · 3 comments
Labels

Comments

@ytsarev
Copy link
Collaborator

ytsarev commented Sep 29, 2022

What problem are you facing?

Currently, we define a Route inline within RouteTable, see /~https://github.com/upbound/official-providers/blob/main/provider-azure/examples/network/routetable.yaml

RouteTable resource: https://marketplace.upbound.io/providers/upbound/provider-azure/latest/resources/network.azure.upbound.io/RouteTable/v1beta1

If we look at https://registry.terraform.io/providers/hashicorp/azurerm/3.8.0/docs/resources/route , we can observe

According to our general strategy documented /~https://github.com/upbound/official-providers/blob/main/docs/new-v1beta1-resource.md?plain=1#L36-L52 we should configure Route as a separate CRD

azurerm_route is also part of Allianz SoW as a result of their terraform state analysis

Provider Name: azure
Provider Version: v0.14.1

How could Official Providers help solve your problem?

  • Configure azurerm_route as a separate resource
  • Adjust azurerm_route_table accordingly with config.MoveToStatus
  • Provide uptest compatible examples
@ytsarev ytsarev added the enhancement New feature or request label Sep 29, 2022
@jeanduplessis jeanduplessis transferred this issue from another repository Oct 10, 2022
@turkenf
Copy link
Collaborator

turkenf commented Apr 11, 2023

  • Configure azurerm_route as a separate resource
  • Provide uptest compatible examples

The azurerm_route resource is configured as uptestable in this PR.

  • Adjust azurerm_route_table accordingly with config.MoveToStatus

This still needs to be done.

Copy link

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Apr 11, 2024
Copy link

This issue is being closed since there has been no activity for 14 days since marking it as stale. If you still need help, feel free to comment or reopen the issue!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants