Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Check for plugin installation directory in meshlab_tools.cmake. #1573

Open
shamefulCake1 opened this issue Feb 10, 2025 · 0 comments

Comments

@shamefulCake1
Copy link

This is a simple patch to avoid a cryptic "missing install target" message from cmake.

I cannot submit a pull request, because of the broken Github 2FA.

diff --git a/src/cmake/meshlab_tools.cmake b/src/cmake/meshlab_tools.cmake
index 4df1f2d4d..14df335df 100644
--- a/src/cmake/meshlab_tools.cmake
+++ b/src/cmake/meshlab_tools.cmake
@@ -4,6 +4,9 @@
 
 #function used to add plugins
 function(add_meshlab_plugin target_name)
+	if(NOT DEFINED MESHLAB_PLUGIN_INSTALL_DIR)
+		message(FATAL_ERROR "MESHLAB_PLUGIN_INSTALL_DIR not defined, check your cmake usage.")
+	endif()
 	set(EXCLUDE_ALL_ARG "")
 	if (MESHLAB_BUILD_MINI)
 		set(EXCLUDE_ALL_ARG "EXCLUDE_FROM_ALL")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant