From 967fbfe75536da3ac25598ba488bef6fb0646e2b Mon Sep 17 00:00:00 2001 From: Elorfin Date: Fri, 17 Feb 2023 07:03:28 +0100 Subject: [PATCH] [Evaluation] rounds score to 100 --- .../Controller/WorkspaceEvaluationController.php | 1 + .../Resources/modules/resource/components/card.jsx | 3 ++- src/main/evaluation/Resources/modules/utils.js | 13 +++++++++++++ .../Resources/modules/workspace/components/card.jsx | 3 ++- 4 files changed, 18 insertions(+), 2 deletions(-) create mode 100644 src/main/evaluation/Resources/modules/utils.js diff --git a/src/main/evaluation/Controller/WorkspaceEvaluationController.php b/src/main/evaluation/Controller/WorkspaceEvaluationController.php index d7544d2ade4..e33742b84b1 100644 --- a/src/main/evaluation/Controller/WorkspaceEvaluationController.php +++ b/src/main/evaluation/Controller/WorkspaceEvaluationController.php @@ -123,6 +123,7 @@ public function listByWorkspaceAction(Workspace $workspace, Request $request): J // don't show all users evaluations if no right if (!$this->checkToolAccess('SHOW_EVALUATIONS', $workspace, false)) { /** @var User $user */ + $user = $this->tokenStorage->getToken()->getUser(); $hiddenFilters['user'] = $user->getUuid(); } diff --git a/src/main/evaluation/Resources/modules/resource/components/card.jsx b/src/main/evaluation/Resources/modules/resource/components/card.jsx index 4826ed2de50..bfeab33a731 100644 --- a/src/main/evaluation/Resources/modules/resource/components/card.jsx +++ b/src/main/evaluation/Resources/modules/resource/components/card.jsx @@ -10,6 +10,7 @@ import {DataCard} from '#/main/app/data/components/card' import {constants} from '#/main/evaluation/constants' import {ResourceEvaluation as ResourceEvaluationTypes} from '#/main/evaluation/resource/prop-types' +import {displayScore} from '#/main/evaluation/utils' const ResourceCard = (props) => icon: 'fa fa-fw fa-award', label: trans('score'), displayed: !!props.data.scoreMax, - value: (number(props.data.score) || 0) + ' / ' + number(props.data.scoreMax) + value: !!props.data.scoreMax && displayScore(props.data.scoreMax, props.data.score, 100) + ' / 100' } ] .filter(item => undefined === item.displayed || item.displayed) diff --git a/src/main/evaluation/Resources/modules/utils.js b/src/main/evaluation/Resources/modules/utils.js new file mode 100644 index 00000000000..345ac179774 --- /dev/null +++ b/src/main/evaluation/Resources/modules/utils.js @@ -0,0 +1,13 @@ +import {number} from '#/main/app/intl' + +function displayScore(scoreMax, score, displayScore) { + if (score) { + return number((score / scoreMax) * displayScore) + '' + } + + return '0'; +} + +export { + displayScore +} \ No newline at end of file diff --git a/src/main/evaluation/Resources/modules/workspace/components/card.jsx b/src/main/evaluation/Resources/modules/workspace/components/card.jsx index 852ce33e90e..39c2fda6d24 100644 --- a/src/main/evaluation/Resources/modules/workspace/components/card.jsx +++ b/src/main/evaluation/Resources/modules/workspace/components/card.jsx @@ -10,6 +10,7 @@ import {DataCard} from '#/main/app/data/components/card' import {constants} from '#/main/evaluation/constants' import {WorkspaceEvaluation as WorkspaceEvaluationTypes} from '#/main/evaluation/workspace/prop-types' +import {displayScore} from '#/main/evaluation/utils' const WorkspaceCard = (props) => icon: 'fa fa-fw fa-award', label: trans('score'), displayed: !!props.data.scoreMax, - value: (number(props.data.score) || 0) + ' / ' + number(props.data.scoreMax) + value: !!props.data.scoreMax && displayScore(props.data.scoreMax, props.data.score, 100) + ' / 100' } ] .filter(item => undefined === item.displayed || item.displayed)