Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE9-11 & Edge - setting editor to readOnly and pressing Ctrl+C removes selection. #1982

Closed
jswiderski opened this issue May 17, 2018 · 5 comments
Labels
browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. browser:ie9 The issue can only be reproduced in the Internet Explorer 9 browser. browser:ie10 The issue can only be reproduced in the Internet Explorer 10 browser. browser:ie11 The issue can only be reproduced in the Internet Explorer 11 browser. resolution:duplicate A duplicate of an already reported issue. support An issue reported by a commercially licensed client. type:bug A bug.

Comments

@jswiderski
Copy link
Contributor

jswiderski commented May 17, 2018

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open this codePen and run it in IE9-11 or Edge browser
  2. Select any part of text and press Ctrl+C

Expected result

It is possible to copy text.

Actual result

Selection dissapears.

Edge does that gracefully and throws:
https://docs.ckeditor.com/ckeditor4/latest/guide/dev_errors.html#range-startcontainer
https://docs.ckeditor.com/ckeditor4/latest/guide/dev_errors.html#range-endcontainer
https://docs.ckeditor.com/ckeditor4/latest/guide/dev_errors.html#selection-fake-reset

IE throws Unspecified error selection.js in line 2202. Code throwing error is sel.addRange( nativeRange );

Other details

Please note this is the same ticket as #1916 I have decided to report a new one because it also has more visual impact on Edge.

@jswiderski jswiderski added type:bug A bug. support An issue reported by a commercially licensed client. status:confirmed An issue confirmed by the development team. browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. browser:ie9 The issue can only be reproduced in the Internet Explorer 9 browser. browser:ie10 The issue can only be reproduced in the Internet Explorer 10 browser. browser:ie11 The issue can only be reproduced in the Internet Explorer 11 browser. labels May 17, 2018
@mlewand
Copy link
Contributor

mlewand commented May 18, 2018

@jswiderski could you check if it's also a regression from 4.7.0?

@Comandeer could you investigate what's causing the issue?

@Comandeer Comandeer self-assigned this May 18, 2018
@jswiderski
Copy link
Contributor Author

@mlewand I must have removed bottom of template by mistake. Yes, problem can be reproduced from CKE 4.7.0 in IE9-11 and Edge.

@Comandeer
Copy link
Member

Comandeer commented May 18, 2018

Isn't it a duplicate of #1184? We have already PR for it #1692 – however it only eliminates thrown error, disabling key handling at the same time as a unintentional side effect.

@mlewand
Copy link
Contributor

mlewand commented Aug 9, 2018

Duplicate of #1916 and is already fixed on #1692.

@mlewand mlewand closed this as completed Aug 9, 2018
@mlewand mlewand added resolution:duplicate A duplicate of an already reported issue. and removed status:confirmed An issue confirmed by the development team. labels Aug 9, 2018
@mlewand
Copy link
Contributor

mlewand commented Aug 10, 2018

A fix for this issue is ready and has been merged to our upcoming release. It will be available in 4.10.1.

However you can already see it on CKEditor preview builds.

I have forked the original codepen so that it uses preview CKE4 build here: https://codepen.io/mlewand/pen/rroRGQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. browser:ie9 The issue can only be reproduced in the Internet Explorer 9 browser. browser:ie10 The issue can only be reproduced in the Internet Explorer 10 browser. browser:ie11 The issue can only be reproduced in the Internet Explorer 11 browser. resolution:duplicate A duplicate of an already reported issue. support An issue reported by a commercially licensed client. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

3 participants