Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use delayIfDetached config for editor set to true by default #102

Closed
sculpt0r opened this issue May 3, 2021 · 3 comments · Fixed by #128
Closed

Use delayIfDetached config for editor set to true by default #102

sculpt0r opened this issue May 3, 2021 · 3 comments · Fixed by #128
Assignees
@sculpt0r
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
1.5.0

Comments

@sculpt0r
Copy link
Contributor

sculpt0r commented May 3, 2021 •
edited by jacekbogdanski
Loading

Are you reporting a feature request or a bug?

Feature

Base on our investigation on ckeditor/ckeditor4#4390 issue and fix we provide for it: ckeditor/ckeditor4#4463. We should use the delayIfDetached config set to true by default in integrations, just to prevent any issue. Also, we need to adjust editor creation: to properly maintain editor data.

ckeditor4-vue/src/ckeditor.js

Line 67 in 69744fb

const editor = this.instance = CKEDITOR[ method ]( element, config );
The above line assumes we get editor instance, but that doesn't have to be true with delayed creation.

Expected result

What is the expected result of the above steps?

Actual result

What is the actual result of the above steps?

Other details

  • Browser: -
  • OS: -
  • Integration version: -
  • CKEditor version: -
  • Installed CKEditor plugins: -
@sculpt0r sculpt0r added size:XS status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc). labels May 3, 2021
@sculpt0r
Copy link
Contributor Author

Blocked until 4.17.0 release.

@sculpt0r sculpt0r added the status:blocked An issue which development is blocked by another issue (internal or external one). label May 14, 2021
@sculpt0r sculpt0r removed the status:blocked An issue which development is blocked by another issue (internal or external one). label Nov 23, 2021
@sculpt0r
Copy link
Contributor Author

Since: /~https://github.com/ckeditor/ckeditor4/releases/tag/4.17.0 - no longer blocked

@jacekbogdanski jacekbogdanski changed the title Use delayIfDetached config for editor set to true by default. Use delayIfDetached config for editor set to true by default Nov 30, 2021
@sculpt0r sculpt0r mentioned this issue Dec 14, 2021
Merged
@sculpt0r sculpt0r self-assigned this Dec 16, 2021
@sculpt0r sculpt0r mentioned this issue Dec 20, 2021
Merged
@sculpt0r sculpt0r added size:S and removed size:XS labels Jan 4, 2022
@CKEditorBot
Copy link
Collaborator

Closed in #128

@jacekbogdanski jacekbogdanski added type:feature A feature request. and removed type:task Any other issue (refactoring, typo fix, etc). labels Jan 12, 2022
@jacekbogdanski jacekbogdanski added this to the 1.5.0 milestone Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sculpt0r sculpt0r

Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Use delayIfDetached as default value in editor config ckeditor/ckeditor4-vue
3 participants
@sculpt0r @jacekbogdanski @CKEditorBot