Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use delayIfDetached config for editor set to true by default. #203

Closed
sculpt0r opened this issue May 3, 2021 · 3 comments
Closed

Use delayIfDetached config for editor set to true by default. #203

sculpt0r opened this issue May 3, 2021 · 3 comments
Labels
status:blocked An issue which development is blocked by another issue (internal or external one). status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).

Comments

@sculpt0r
Copy link
Contributor

sculpt0r commented May 3, 2021

Are you reporting a feature request or a bug?

Task.

Base on our investigation on ckeditor/ckeditor4#4390 issue and fix we provide for it: ckeditor/ckeditor4#4463. We should use the delayIfDetached config set to true by default in integrations, just to prevent any issue. Also, we need to adjust editor creation: to properly maintain editor data

const editor = this.editor = CKEDITOR[ constructor ]( this.element, config );
The above line assumes we get editor instance, but that doesn't have to be true with delayed creation.

Expected result

What is the expected result of the above steps?

Actual result

What is the actual result of the above steps?

Other details

  • Browser: -
  • OS: -
  • Integration version: -
  • CKEditor version: -
  • Installed CKEditor plugins: -
@sculpt0r sculpt0r added size:XS status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc). labels May 3, 2021
@sculpt0r
Copy link
Contributor Author

Blocked until 4.17.0 release.

@sculpt0r sculpt0r added the status:blocked An issue which development is blocked by another issue (internal or external one). label May 14, 2021
@sculpt0r
Copy link
Contributor Author

@MMMalik - Am I good remember that we talked, that this issue could be closed due to nature of component creation in react? If so - we may close it 👾

@MMMalik
Copy link
Contributor

MMMalik commented Jul 23, 2021

I tested nightly build of ckeditor with both v1 and v2 ckeditor4-react and I haven't spotted any issues. I think we close this task for now.

@MMMalik MMMalik closed this as completed Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:blocked An issue which development is blocked by another issue (internal or external one). status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Development

No branches or pull requests

2 participants