Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ckeditorComponent.disabled to ...readOnly #2

Closed
engineering-this opened this issue Oct 26, 2018 · 1 comment · Fixed by #1
Closed

Rename ckeditorComponent.disabled to ...readOnly #2

engineering-this opened this issue Oct 26, 2018 · 1 comment · Fixed by #1
Milestone

Comments

@engineering-this
Copy link
Contributor

According to specs:
disabled This Boolean attribute indicates that the user cannot interact with the control. If this attribute is not specified, the control inherits its setting from the containing element, for example if there is no containing element when the disabled attribute is set, the control is enabled.
readonly This Boolean attribute indicates that the user cannot modify the value of the control. Unlike the disabled attribute, the readonly attribute does not prevent the user from clicking or selecting in the control. The value of a read-only control is still submitted with the form.

CKEDITOR doesn't support disabled state, so we shouldn't use disabled as alias for read only, because this might be misleading.

@engineering-this
Copy link
Contributor Author

Closed by #1

f1ames added a commit that referenced this issue Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants