Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ ☂️ ] Fix tests so CI could be green again #113

Closed
f1ames opened this issue Jun 19, 2020 · 1 comment
Closed

[ ☂️ ] Fix tests so CI could be green again #113

f1ames opened this issue Jun 19, 2020 · 1 comment
Assignees
@hub33k
Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).

Comments

@f1ames
Copy link
Contributor

f1ames commented Jun 19, 2020

Are you reporting a feature request or a bug?

Task

Provide detailed reproduction steps (if any)

We have an issue that CI is red for some time now due to failing tests (see /~https://github.com/ckeditor/ckeditor4-angular/issues?q=is%3Aopen+is%3Aissue+label%3Atype%3Afailingtest). It would be good to fix this and have green CI again.
@f1ames f1ames added status:confirmed An issue confirmed by the development team. workload:medium type:task Any other issue (refactoring, typo fix, etc). labels Jun 19, 2020
@hub33k hub33k self-assigned this Jun 26, 2020
@Dumluregn Dumluregn changed the title Fix tests so CI could be green again [ ☂️ ] Fix tests so CI could be green again Jul 22, 2020
@f1ames
Copy link
Contributor Author

f1ames commented Sep 16, 2020

Fixed in #133 🎉

@f1ames f1ames closed this as completed Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hub33k hub33k

Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@f1ames @hub33k