-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: Tilde expansion in Cmder #689
Comments
v1.1.8 is when tilde expansion was added (Dec 11, 2020). Commit c42b, line 608. It was part of changes for compatibility for scripts from v0.4.9. Since I had started adding tilde expansion in v1.1.6 (which you pinpointed), the tilde expansion was an implicit part of the new code. So it didn't manage to make it into the release notes as a description of a specific change. Also, this question made me discover a typo in the docs for clink.filematches() and clink.dirmatches() -- they were both added in v1.1.8, not in v1.1. 1 8. I've updated the docs, and the update will go live with the next Clink update (probably in a couple of weeks). |
Re: "equivalent code in Clink": I cited commit c42b line 608, but in reality it's a little more complicated than just that. Because there are multiple different spots where tilde expansion can happen, depending on context and how completions are invoked and certain settings, and it's grown more sophisticated over time. And IIRC, I think Martin built it into a couple of other spots sometime between v0.4.9 and v1.0.0, but in C++ code, and in a way that wasn't guaranteed to always be invoked. I believe v1.1.8 is when it was first hooked up in a consistent and mainstream way. But either way, it's been around for roughly 4 years, give or take a little, even if a precise single date is a little fuzzy to track down. 😁 |
Yes, and ideally the script would be removed or commented out, to avoid interfering with the built in functionality. |
Thank you for the through investigation and the excellent information which were exactly what I was looking for, Chris! 👍🏻 I'm going to put a small notice in Cmder that using such scripts is no longer necessary if clink >= 1.1.8 is installed. As always, thanks for the amazing clink! 😄 ❤️ |
Hi there @chrisant996,
I am doing some cleaning up in the Cmder repo, and noticed an issue which has some user contributed lua scripts for the tilde expansion feature on auto complete (i.e. pressing tab).
Now doing a quick search for the word "tilde" on the releases page I wasn't able to pinpoint the exact release of clink that added support for this to read the docs.
This is the script in question. I just wanted to make sure if I can mark this as "deprecated" so long as clink is supporting this natively. I might be mistaken, in which case I would appreciate it if you could help me clear the confusion.
cmderdev/cmder#1051 (comment)
If this is the case, may I please ask for the equivalent code in clink, just to make a quick comparison?
Thank you!
The text was updated successfully, but these errors were encountered: