App failed to load renderer page when path contains hash sign (#) in Windows prod

[Tanimodori]

Describe the bug
The production build of this app won't load the renderer page when its path contains hash sign in Windows.

To Reproduce
Steps to reproduce the behavior:

git clone /~https://github.com/cawa-93/vite-electron-builder.git
cd vite-electron-builder
npm i
npm run compile
cd dist
mv win-unpacked #
cd #
./vite-electron-builder.exe

Expected behavior
The app will run normally

Screenshots

Additional context
This is a known issue that WHATWG URL API doesn't expect # shown in the path of URL and interpret it as anchor of the web page. Nodejs legacy URL provides better support for native URLs. The WHATWG URL API that Nodejs adopted is not fully compatible with the legacy URL APIs.

There are solutions using url.parse. But unfortunately it is marked as "deprecated" rather than "legacy" for unknown reason despite the nodejs team said "We've backed off the deprecation of the legacy API". I propose that we can use BrowserWindow.loadFile provided by electron since it is not marked as deprecated or legacy yet. Although I suppose it uses those Nodejs legacy URL API internally lol.

See also

• Relative URLs in WHATWG URL API nodejs/node#12682
• App fails to load files when app path contains a # (hashtag) electron/electron#6869

[cawa-93]

npm run compile is not actually production build, because in real production build all app's files are packed into asar archive. That case should be tested as well. To do that, you can change compile command like so:

cross-env MODE=production npm run build && electron-builder build --config .electron-builder.config.js

[Tanimodori]

npm run compile is not actually production build, because in real production build all app's files are packed into asar archive. That case should be tested as well. To do that, you can change compile command like so:

cross-env MODE=production npm run build && electron-builder build --config .electron-builder.config.js

I've tested the pr with this build command which works in my local env.

[cawa-93]

I mean, does issue with # reproduces in "real production" build?

[Tanimodori]

It is reproducable with the actual prod build command on the original repo. Just modify the path to include a "#".

[Tanimodori]

Thanks!