From 838d693f35eadcb2e276d9964ea4dcbf47430796 Mon Sep 17 00:00:00 2001 From: Nico Korthout Date: Tue, 6 Dec 2022 10:15:16 +0100 Subject: [PATCH] ci: use major version for actions/setup-java It might be better to switch the version to the latest major release v3. Such tags are generally moved with every new minor and patch release of the major version. This practice is officially recommended by GH. Note that this may result in reduced reproducibility. However, since all tags can be moved, the only way to guarantee reproducibility is by pinning specific commit shas. Likely it is easiest for us when using actions like these (e.g. checkout) to use the major version tag. --- .github/workflows/build-test.yml | 8 ++++---- .github/workflows/deploy-artifact.yml | 2 +- .github/workflows/snapshot-test.yml | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 1dc0a686e..354c0e4d0 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -16,7 +16,7 @@ jobs: uses: actions/checkout@v3 - name: Set up Java environment - uses: actions/setup-java@v3.6.0 + uses: actions/setup-java@v3 with: distribution: temurin java-version: 17 @@ -44,7 +44,7 @@ jobs: uses: actions/checkout@v3 - name: Set up Java environment - uses: actions/setup-java@v3.6.0 + uses: actions/setup-java@v3 with: distribution: temurin java-version: 17 @@ -75,7 +75,7 @@ jobs: uses: actions/checkout@v3 - name: Set up Java environment - uses: actions/setup-java@v3.6.0 + uses: actions/setup-java@v3 with: distribution: temurin java-version: 17 @@ -100,7 +100,7 @@ jobs: IMAGE_TAG_KEY: container.image.tag - name: Downgrade Java environment - uses: actions/setup-java@v3.6.0 + uses: actions/setup-java@v3 with: distribution: temurin java-version: 8 diff --git a/.github/workflows/deploy-artifact.yml b/.github/workflows/deploy-artifact.yml index 1848c6719..8ecf470f0 100644 --- a/.github/workflows/deploy-artifact.yml +++ b/.github/workflows/deploy-artifact.yml @@ -46,7 +46,7 @@ jobs: secret/data/github.com/organizations/camunda MAVEN_CENTRAL_GPG_SIGNING_KEY_SEC; - name: Set up Java environment - uses: actions/setup-java@v3.6.0 + uses: actions/setup-java@v3 with: distribution: temurin java-version: 17 diff --git a/.github/workflows/snapshot-test.yml b/.github/workflows/snapshot-test.yml index 00e73bd98..ef6f76f23 100644 --- a/.github/workflows/snapshot-test.yml +++ b/.github/workflows/snapshot-test.yml @@ -14,7 +14,7 @@ jobs: uses: actions/checkout@v3 - name: Set up Java environment - uses: actions/setup-java@v3.6.0 + uses: actions/setup-java@v3 with: distribution: temurin java-version: 17