Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QCheck int shrinker produces duplicates #241

Closed
jmid opened this issue Apr 20, 2022 · 0 comments · Fixed by #277
Closed

QCheck int shrinker produces duplicates #241

jmid opened this issue Apr 20, 2022 · 0 comments · Fixed by #277

Comments

@jmid
Copy link
Collaborator

jmid commented Apr 20, 2022

As part of #235 I was reminded of the following - which we should address and track separately:

The duplicate 0 testing of the improved int shrinker is unsatisfying, but so is the duplicate output of the current int shrinker:

let test_int () =
List.iter (alco_check Alcotest.int (trace_false Shrink.int) "on repeated failure")
[ ("int 100", 100, [50; 75; 88; 94; 97; 99; 99]); (*WTF?*)
("int 1000", 1000, [500; 750; 875; 938; 969; 985; 993; 997; 999; 999]); (*WTF?*)
("int (-26)", -26, [-13; -20; -23; -25; -25]) ]; (*WTF?*)

Originally posted by @jmid in #235 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant