-
Notifications
You must be signed in to change notification settings - Fork 29
Clicking "New Build" when looking at a specific build or a "Builds for branch" could autofill that branch #623
Comments
@huonw Awesome — I like this idea! |
So we've gone back and forth on this over the many years of Buildkite. For a period we had this exact behaviour (sans the radio boxes) and many people asked for it to be consistently the "default branch" (which in your case @huonw is We ended up sticking with the "just keep it the same" all the time to make it sink into muscle memory what the value is. If you use manual build creation quite a bit, you may forget that we do the magical branch-detection, and accidentally trigger a build with the wrong branch. As annoying as it is to change it when you need to, at least your brain remembers to change it. More than happy to revisit this stuff if we can make it work better! Maybe the radio boxes would work better? Or some other UI where there are some pre-filled branches with a text box for "other" (where you have to make at least one selection) If you'd like to see something now @huonw - one idea I had was for you to upload a custom Buildkite annotation that includes a link like this: https://buildkite.com/org/pipeline#new?message=blah&branch=foo&commit=da-commit (essentially making your own "New Build" button with your own defaults) |
The current behaviour makes sense given people have muscle memory, and things changing unexpectedly/subtly is never good!
I guess the radio buttons could have the repo's default branch checked by default, but still offer the current one for quick access. That said, even some form of autocomplete/dropdown of known branches would be enough too.
Unfortunately I don't think this quite handles what I was using "New Build" for: testing out some variations of a new CI feature (uploading and downloading a tarball of the download cache directories of a package manager (SBT), to avoid having to redownload them all individually) with some of its options controlled by environment variables, on a couple of different short lived branches. This means I'd want more than one annotation and they're only useful for a short period, until the feature is finished (at which time, the optimal options get written directly into our pipeline/scripts and no manual builds of this form are needed). (Thanks for the tip about the |
For instance:
In that image, I'm on https://buildkite.com/.../builds?branch=feature%2Fsplit-pipeline, that is, the list of builds for the
feature/split-pipeline
branch. I clicked "New Build", and it suggested "develop". As suggested in the image, it could instead suggest thefeature/split-pipeline
branch. The same would be true if I was looking at a specific build of this branch (the build in the background of the image is number 324, so if I was on https://buildkite.com/.../builds/324).If there's an expectation that most "New Builds" would be on the repo's default branch, alternatives could be:
(Or possibly all three: radio boxes, with the current branch chosen by default, along with autocompletion in the Other box!)
The text was updated successfully, but these errors were encountered: