From 16457c3eee74fdf12d0056598656ccdc7151a955 Mon Sep 17 00:00:00 2001
From: bonnie <bonnie@57blocks.com>
Date: Mon, 8 Apr 2024 14:28:45 +0800
Subject: [PATCH] Refactor code

---
 packages/core-sdk/protocol-contracts                       | 1 -
 packages/core-sdk/src/constants/common.ts                  | 3 ---
 .../integration/storyTestNet/royalty.storyTest.test.ts     | 7 ++-----
 3 files changed, 2 insertions(+), 9 deletions(-)
 delete mode 160000 packages/core-sdk/protocol-contracts

diff --git a/packages/core-sdk/protocol-contracts b/packages/core-sdk/protocol-contracts
deleted file mode 160000
index 50ae4c0c..00000000
--- a/packages/core-sdk/protocol-contracts
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit 50ae4c0c3ee44b71e151ceb81333790a19342bc5
diff --git a/packages/core-sdk/src/constants/common.ts b/packages/core-sdk/src/constants/common.ts
index 72c4eda7..960e39c4 100644
--- a/packages/core-sdk/src/constants/common.ts
+++ b/packages/core-sdk/src/constants/common.ts
@@ -3,6 +3,3 @@ export const AddressZero = "0x0000000000000000000000000000000000000000";
 export const HashZero = "0x0000000000000000000000000000000000000000000000000000000000000000";
 
 export const SepoliaChainId = "11155111";
-
-export const maxValueForApproval =
-  "115792089237316195423570985008687907853269984665640564039457584007913129639935";
diff --git a/packages/core-sdk/test/integration/storyTestNet/royalty.storyTest.test.ts b/packages/core-sdk/test/integration/storyTestNet/royalty.storyTest.test.ts
index 2f6de7d7..0a641270 100644
--- a/packages/core-sdk/test/integration/storyTestNet/royalty.storyTest.test.ts
+++ b/packages/core-sdk/test/integration/storyTestNet/royalty.storyTest.test.ts
@@ -23,9 +23,9 @@ import {
 import chaiAsPromised from "chai-as-promised";
 import { storyTestnetAddress } from "../../env";
 import { chainStringToViemChain, waitTx } from "../../../src/utils/utils";
-import { maxValueForApproval } from "../../../src/constants/common";
 chai.use(chaiAsPromised);
 const expect = chai.expect;
+
 describe.skip("Test royalty Functions", () => {
   let client: StoryClient;
   let senderAddress: string;
@@ -186,10 +186,7 @@ describe.skip("Test royalty Functions", () => {
         abi: abi,
         address: storyTestnetAddress.MockERC20,
         functionName: "approve",
-        args: [
-          client.royalty.royaltyPolicyLAPConfig.address,
-          maxValueForApproval as unknown as bigint,
-        ],
+        args: [client.royalty.royaltyPolicyLAPConfig.address, BigInt(100)],
         account: walletClient.account,
       });
       const approveHash = await walletClient.writeContract(call);