Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deprecating rotate_left #26

Open
scottmcm opened this issue Dec 17, 2018 · 1 comment
Open

Consider deprecating rotate_left #26

scottmcm opened this issue Dec 17, 2018 · 1 comment

Comments

@scottmcm
Copy link

scottmcm commented Dec 17, 2018

Now that https://doc.rust-lang.org/std/primitive.slice.html#method.rotate_left is stable (1.26), consider deprecating the implementation here. Note that they're not identical; in the std version the shift length isn't modulo the array length. The std version is notably faster than this rotate implementation, however.

@bluss
Copy link
Owner

bluss commented Dec 17, 2018

This whole crate is rusting! Thanks though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants