From 593f39247c75ceac43750e4d9bea63f4d3214fcc Mon Sep 17 00:00:00 2001 From: Kat Leight Date: Thu, 11 May 2023 14:57:43 -0600 Subject: [PATCH 01/14] move default position to bottomRight --- packages/core/package.json | 2 +- packages/core/src/constants.ts | 2 +- packages/demo/package.json | 2 +- packages/react/package.json | 4 ++-- packages/vue/package.json | 4 ++-- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/core/package.json b/packages/core/package.json index bb7a99bd5..510f92841 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -1,6 +1,6 @@ { "name": "@web3-onboard/core", - "version": "2.18.0", + "version": "2.18.1-alpha.1", "description": "Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [ "Ethereum", diff --git a/packages/core/src/constants.ts b/packages/core/src/constants.ts index 7fdc27265..e226d7833 100644 --- a/packages/core/src/constants.ts +++ b/packages/core/src/constants.ts @@ -7,7 +7,7 @@ export const APP_INITIAL_STATE: AppState = { chains: [], accountCenter: { enabled: true, - position: 'topRight', + position: 'bottomRight', expanded: false, minimal: configuration.device.type === 'mobile' }, diff --git a/packages/demo/package.json b/packages/demo/package.json index 19abec5cc..3cc370d03 100644 --- a/packages/demo/package.json +++ b/packages/demo/package.json @@ -24,7 +24,7 @@ "webpack-dev-server": "4.7.4" }, "dependencies": { - "@web3-onboard/core": "^2.18.0", + "@web3-onboard/core": "^2.18.1-alpha.1", "@web3-onboard/coinbase": "^2.2.3", "@web3-onboard/transaction-preview": "^2.0.7", "@web3-onboard/dcent": "^2.2.6", diff --git a/packages/react/package.json b/packages/react/package.json index e7cf5425b..072f7ceb2 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -1,6 +1,6 @@ { "name": "@web3-onboard/react", - "version": "2.8.2", + "version": "2.8.3-alpha.1", "description": "A collection of React hooks for integrating Web3-Onboard in to React and Next.js projects. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [ "Ethereum", @@ -62,7 +62,7 @@ "typescript": "^4.5.5" }, "dependencies": { - "@web3-onboard/core": "^2.18.0", + "@web3-onboard/core": "^2.18.1-alpha.1", "@web3-onboard/common": "^2.3.2", "use-sync-external-store": "1.0.0" }, diff --git a/packages/vue/package.json b/packages/vue/package.json index 5832ba042..519c5784c 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -1,6 +1,6 @@ { "name": "@web3-onboard/vue", - "version": "2.7.1", + "version": "2.7.2-alpha.1", "description": "A collection of Vue Composables for integrating Web3-Onboard in to a Vue or Nuxt project. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [ "Ethereum", @@ -63,7 +63,7 @@ "@vueuse/core": "^8.4.2", "@vueuse/rxjs": "^8.2.0", "@web3-onboard/common": "^2.3.2", - "@web3-onboard/core": "^2.18.0", + "@web3-onboard/core": "^2.18.1-alpha.1", "vue-demi": "^0.12.4" }, "peerDependencies": { From a46a006186aecd13868ac22825ebf90d82016561 Mon Sep 17 00:00:00 2001 From: Kat Leight Date: Thu, 11 May 2023 16:58:57 -0600 Subject: [PATCH 02/14] changes to minimized --- packages/core/src/views/Index.svelte | 1 - .../src/views/account-center/Index.svelte | 9 +- .../src/views/account-center/Maximized.svelte | 6 + .../src/views/account-center/Minimized.svelte | 182 ++++-------------- 4 files changed, 50 insertions(+), 148 deletions(-) diff --git a/packages/core/src/views/Index.svelte b/packages/core/src/views/Index.svelte index 57e612a54..798e5fdd5 100644 --- a/packages/core/src/views/Index.svelte +++ b/packages/core/src/views/Index.svelte @@ -378,7 +378,6 @@ .container { padding: 16px; font-family: var(--onboard-font-family-normal, var(--font-family-normal)); - width: 100%; pointer-events: none; touch-action: none; } diff --git a/packages/core/src/views/account-center/Index.svelte b/packages/core/src/views/account-center/Index.svelte index 22097d111..2d87b6b19 100644 --- a/packages/core/src/views/account-center/Index.svelte +++ b/packages/core/src/views/account-center/Index.svelte @@ -31,9 +31,12 @@ {/if} -{:else if !$accountCenter$.expanded && !$accountCenter$.minimal} - - +{:else if !$accountCenter$.minimal} + {#if $accountCenter$.expanded} + + {/if} + + {:else if !$accountCenter$.expanded && $accountCenter$.minimal} diff --git a/packages/core/src/views/account-center/Maximized.svelte b/packages/core/src/views/account-center/Maximized.svelte index f31a3823b..ae5f8a42b 100644 --- a/packages/core/src/views/account-center/Maximized.svelte +++ b/packages/core/src/views/account-center/Maximized.svelte @@ -1,4 +1,5 @@
-
+ +
+ +
+
- -
- -
-
+
- - -
-
- {ensName - ? shortenDomain(ensName) - : unsName - ? shortenDomain(unsName) - : shortenedFirstAddress} -
- {#if firstAddressBalance} -
- {firstAddressBalance.length > 7 - ? firstAddressBalance.slice(0, 7) - : firstAddressBalance} - {firstAddressAsset} -
- {/if} -
- - -
-
-
-
- {@html validAppChain - ? validAppChain.icon || - (defaultChainStyles && defaultChainStyles.icon) || - unrecognizedChainStyle.icon - : warningIcon} -
- - -
-
-
-
From 3832095d7a57b1a5bb1b2ce7cca200dc856be28a Mon Sep 17 00:00:00 2001 From: Kat Leight Date: Thu, 11 May 2023 17:04:56 -0600 Subject: [PATCH 03/14] toggle on minimized click --- packages/core/src/views/account-center/Index.svelte | 4 +++- .../core/src/views/account-center/Minimized.svelte | 11 ++++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/packages/core/src/views/account-center/Index.svelte b/packages/core/src/views/account-center/Index.svelte index 2d87b6b19..7fca135db 100644 --- a/packages/core/src/views/account-center/Index.svelte +++ b/packages/core/src/views/account-center/Index.svelte @@ -23,7 +23,7 @@ } - + {#if mountInContainer} {#if $wallets$.length} @@ -32,11 +32,13 @@
{/if} {:else if !$accountCenter$.minimal} +
{#if $accountCenter$.expanded} {/if} +
{:else if !$accountCenter$.expanded && $accountCenter$.minimal} diff --git a/packages/core/src/views/account-center/Minimized.svelte b/packages/core/src/views/account-center/Minimized.svelte index 25715eb1b..670a4a0db 100644 --- a/packages/core/src/views/account-center/Minimized.svelte +++ b/packages/core/src/views/account-center/Minimized.svelte @@ -1,4 +1,5 @@ @@ -114,7 +119,7 @@
From 1e4e0e0e0961278c2a41173f40841444ca7419d8 Mon Sep 17 00:00:00 2001 From: Kat Leight Date: Mon, 15 May 2023 16:45:20 -0600 Subject: [PATCH 04/14] fix transition --- .../src/views/account-center/Index.svelte | 33 ++-- .../src/views/account-center/Maximized.svelte | 12 +- .../src/views/account-center/Micro.svelte | 63 ++++-- .../src/views/account-center/Minimized.svelte | 184 ++++++++++++++---- 4 files changed, 212 insertions(+), 80 deletions(-) diff --git a/packages/core/src/views/account-center/Index.svelte b/packages/core/src/views/account-center/Index.svelte index 7fca135db..e0d0a47d7 100644 --- a/packages/core/src/views/account-center/Index.svelte +++ b/packages/core/src/views/account-center/Index.svelte @@ -1,48 +1,47 @@ - - -{#if mountInContainer} - {#if $wallets$.length} -
- -
- {/if} -{:else if !$accountCenter$.minimal} +{#if !$accountCenter$.minimal}
- {#if $accountCenter$.expanded} + {#if $accountCenter$.position.includes('bottom')} {/if} + {#if $accountCenter$.position.includes('top')} + + {/if}
-{:else if !$accountCenter$.expanded && $accountCenter$.minimal} +{:else if $accountCenter$.minimal} +
+ {#if $accountCenter$.position.includes('bottom')} + + {/if} -{:else} - - + {#if $accountCenter$.position.includes('top')} + + {/if} +
{/if} diff --git a/packages/core/src/views/account-center/Maximized.svelte b/packages/core/src/views/account-center/Maximized.svelte index ae5f8a42b..a1d577cdd 100644 --- a/packages/core/src/views/account-center/Maximized.svelte +++ b/packages/core/src/views/account-center/Maximized.svelte @@ -1,7 +1,7 @@ -
+
diff --git a/packages/core/src/views/account-center/Minimized.svelte b/packages/core/src/views/account-center/Minimized.svelte index 670a4a0db..9ddca9c9e 100644 --- a/packages/core/src/views/account-center/Minimized.svelte +++ b/packages/core/src/views/account-center/Minimized.svelte @@ -66,23 +66,15 @@
- -
- -
-
+
+ +
+ +
-
+
+ + +
+
+ {ensName + ? shortenDomain(ensName) + : unsName + ? shortenDomain(unsName) + : shortenedFirstAddress} +
+ {#if firstAddressBalance} +
+ {firstAddressBalance.length > 7 + ? firstAddressBalance.slice(0, 7) + : firstAddressBalance} + {firstAddressAsset} +
+ {/if} +
+ + +
+
+
+
+ {@html validAppChain + ? validAppChain.icon || + (defaultChainStyles && defaultChainStyles.icon) || + unrecognizedChainStyle.icon + : warningIcon} +
+ + +
+
+
+
-
+
\ No newline at end of file From 10ff1049176e8f8e6cbbbebe753d273a57d0b2ce Mon Sep 17 00:00:00 2001 From: Kat Leight Date: Mon, 15 May 2023 17:09:04 -0600 Subject: [PATCH 05/14] fix jump on transition --- packages/core/package.json | 2 +- packages/core/src/views/account-center/Index.svelte | 4 ++-- packages/core/src/views/account-center/Maximized.svelte | 1 - packages/demo/package.json | 2 +- packages/react/package.json | 8 ++------ packages/vue/package.json | 8 ++------ 6 files changed, 8 insertions(+), 17 deletions(-) diff --git a/packages/core/package.json b/packages/core/package.json index 8966e3930..b20388dd9 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -1,6 +1,6 @@ { "name": "@web3-onboard/core", - "version": "2.18.1-alpha.2", + "version": "2.18.1-alpha.3", "description": "Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [ "Ethereum", diff --git a/packages/core/src/views/account-center/Index.svelte b/packages/core/src/views/account-center/Index.svelte index e0d0a47d7..1d9766ece 100644 --- a/packages/core/src/views/account-center/Index.svelte +++ b/packages/core/src/views/account-center/Index.svelte @@ -23,7 +23,7 @@ {#if !$accountCenter$.minimal} -
+
{#if $accountCenter$.position.includes('bottom')} {/if} @@ -34,7 +34,7 @@ {/if}
{:else if $accountCenter$.minimal} -
+
{#if $accountCenter$.position.includes('bottom')} diff --git a/packages/core/src/views/account-center/Maximized.svelte b/packages/core/src/views/account-center/Maximized.svelte index a1d577cdd..b33fe3a03 100644 --- a/packages/core/src/views/account-center/Maximized.svelte +++ b/packages/core/src/views/account-center/Maximized.svelte @@ -274,7 +274,6 @@ {#if $accountCenter$.expanded}
>>>>>> develop + "version": "2.8.3-alpha.3", "description": "A collection of React hooks for integrating Web3-Onboard in to React and Next.js projects. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [ "Ethereum", @@ -66,7 +62,7 @@ "typescript": "^4.5.5" }, "dependencies": { - "@web3-onboard/core": "^2.18.1-alpha.2", + "@web3-onboard/core": "^2.18.1-alpha.3", "@web3-onboard/common": "^2.3.2", "use-sync-external-store": "1.0.0" }, diff --git a/packages/vue/package.json b/packages/vue/package.json index 026eb4512..7e21ef5dc 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -1,10 +1,6 @@ { "name": "@web3-onboard/vue", -<<<<<<< HEAD - "version": "2.7.2-alpha.1", -======= - "version": "2.7.2-alpha.2", ->>>>>>> develop + "version": "2.7.2-alpha.3", "description": "A collection of Vue Composables for integrating Web3-Onboard in to a Vue or Nuxt project. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.", "keywords": [ "Ethereum", @@ -67,7 +63,7 @@ "@vueuse/core": "^8.4.2", "@vueuse/rxjs": "^8.2.0", "@web3-onboard/common": "^2.3.2", - "@web3-onboard/core": "^2.18.1-alpha.2", + "@web3-onboard/core": "^2.18.1-alpha.3", "vue-demi": "^0.12.4" }, "peerDependencies": { From 0917993cae8fd304cfcde7544be4bcf7afe57b29 Mon Sep 17 00:00:00 2001 From: Kat Leight Date: Tue, 16 May 2023 10:23:41 -0600 Subject: [PATCH 06/14] rename components --- ...mized.svelte => AccountCenterPanel.svelte} | 386 +++++++++--------- ...d.svelte => AcctCenterTriggerLarge.svelte} | 2 +- ...o.svelte => AcctCenterTriggerSmall.svelte} | 9 +- .../src/views/account-center/Index.svelte | 36 +- 4 files changed, 211 insertions(+), 222 deletions(-) rename packages/core/src/views/account-center/{Maximized.svelte => AccountCenterPanel.svelte} (52%) rename packages/core/src/views/account-center/{Minimized.svelte => AcctCenterTriggerLarge.svelte} (99%) rename packages/core/src/views/account-center/{Micro.svelte => AcctCenterTriggerSmall.svelte} (93%) diff --git a/packages/core/src/views/account-center/Maximized.svelte b/packages/core/src/views/account-center/AccountCenterPanel.svelte similarity index 52% rename from packages/core/src/views/account-center/Maximized.svelte rename to packages/core/src/views/account-center/AccountCenterPanel.svelte index b33fe3a03..609b9be42 100644 --- a/packages/core/src/views/account-center/Maximized.svelte +++ b/packages/core/src/views/account-center/AccountCenterPanel.svelte @@ -269,222 +269,222 @@ /> {/if} - - {#if $accountCenter$.expanded} -
- -
- -
-
- {#each $wallets$ as wallet, i (wallet.label)} - - {/each} -
- -
- - {#if device.type === 'desktop'} - -
connect()} - class="action-container flex items-center pointer" - > -
- {@html plusCircleIcon} -
- {$_('accountCenter.connectAnotherWallet', { - default: en.accountCenter.connectAnotherWallet - })} + +
+ +
+
+ {#each $wallets$ as wallet, i (wallet.label)} + + {/each} +
+ +
+ + {#if device.type === 'desktop'} + +
connect()} + class="action-container flex items-center pointer" > -
- - -
(disconnectConfirmModal = true)} - class="action-container flex items-center mt pointer" - > -
- {@html arrowForwardIcon} +
+ {@html plusCircleIcon} +
+ {$_('accountCenter.connectAnotherWallet', { + default: en.accountCenter.connectAnotherWallet + })}
- {$_('accountCenter.disconnectAllWallets', { - default: en.accountCenter.disconnectAllWallets - })} -
- {/if} -
-
- -
-
- -
- - - {#if validAppChain} +
(disconnectConfirmModal = true)} + class="action-container flex items-center mt pointer" > - +
+ {@html arrowForwardIcon} +
+ {$_('accountCenter.disconnectAllWallets', { + default: en.accountCenter.disconnectAllWallets + })}
{/if}
+
- -
-
- {$_('accountCenter.currentNetwork', { - default: en.accountCenter.currentNetwork - })} -
-
- +
+
+ +
+ -
-
-
- -
- {#if appMetadata} -
- -
- -
- {(appMetadata && appMetadata.name) || 'App Name'} + {#if validAppChain} +
+
-
+ {/if} +
-
- {(appMetadata && appMetadata.description) || - 'This app has not added a description.'} + +
+
+ {$_('accountCenter.currentNetwork', { + default: en.accountCenter.currentNetwork + })} +
+
+
+
- - {#if appMetadata.gettingStartedGuide || appMetadata.explore} -
-
- {$_('accountCenter.appInfo', { - default: en.accountCenter.appInfo - })} + +
+ {#if appMetadata} +
+ +
+ +
+ {(appMetadata && appMetadata.name) || 'App Name'} +
- {#if appMetadata.gettingStartedGuide} -
-
- {$_('accountCenter.learnMore', { - default: en.accountCenter.learnMore - })} -
- - {$_('accountCenter.gettingStartedGuide', { - default: en.accountCenter.gettingStartedGuide - })} - +
+ {(appMetadata && appMetadata.description) || + 'This app has not added a description.'} +
+
+ + + {#if appMetadata.gettingStartedGuide || appMetadata.explore} +
+
+ {$_('accountCenter.appInfo', { + default: en.accountCenter.appInfo + })}
- {/if} - - {#if appMetadata.explore} -
-
- {$_('accountCenter.smartContracts', { - default: en.accountCenter.smartContracts - })} + + {#if appMetadata.gettingStartedGuide} +
+
+ {$_('accountCenter.learnMore', { + default: en.accountCenter.learnMore + })} +
+ + {$_('accountCenter.gettingStartedGuide', { + default: en.accountCenter.gettingStartedGuide + })} +
- - {$_('accountCenter.explore', { - default: en.accountCenter.explore - })} - -
- {/if} -
+ {/if} + + {#if appMetadata.explore} +
+
+ {$_('accountCenter.smartContracts', { + default: en.accountCenter.smartContracts + })} +
+ + {$_('accountCenter.explore', { + default: en.accountCenter.explore + })} + +
+ {/if} +
+ {/if} + {/if} + {#if secondaryTokens && secondaryTokens.length} + {/if} - {/if} - {#if secondaryTokens && secondaryTokens.length} - - {/if} -
-
-{/if} \ No newline at end of file +{/if} diff --git a/packages/core/src/views/account-center/Minimized.svelte b/packages/core/src/views/account-center/AcctCenterTriggerLarge.svelte similarity index 99% rename from packages/core/src/views/account-center/Minimized.svelte rename to packages/core/src/views/account-center/AcctCenterTriggerLarge.svelte index e26d4536e..5c0e87098 100644 --- a/packages/core/src/views/account-center/Minimized.svelte +++ b/packages/core/src/views/account-center/AcctCenterTriggerLarge.svelte @@ -258,4 +258,4 @@
-
\ No newline at end of file +
diff --git a/packages/core/src/views/account-center/Micro.svelte b/packages/core/src/views/account-center/AcctCenterTriggerSmall.svelte similarity index 93% rename from packages/core/src/views/account-center/Micro.svelte rename to packages/core/src/views/account-center/AcctCenterTriggerSmall.svelte index ac516b955..09c96d6da 100644 --- a/packages/core/src/views/account-center/Micro.svelte +++ b/packages/core/src/views/account-center/AcctCenterTriggerSmall.svelte @@ -3,10 +3,7 @@ import { wallets$ } from '../../streams.js' import { updateAccountCenter } from '../../store/actions.js' import { questionIcon } from '../../icons/index.js' - import { - WalletAppBadge, - SuccessStatusIcon - } from '../shared/index.js' + import { WalletAppBadge, SuccessStatusIcon } from '../shared/index.js' import { state } from '../../store/index.js' import { configuration } from '../../configuration.js' @@ -80,7 +77,9 @@
diff --git a/packages/core/src/views/account-center/Index.svelte b/packages/core/src/views/account-center/Index.svelte index 1d9766ece..1aad411df 100644 --- a/packages/core/src/views/account-center/Index.svelte +++ b/packages/core/src/views/account-center/Index.svelte @@ -3,9 +3,9 @@ import { updateAccountCenter } from '../../store/actions.js' import { state } from '../../store/index.js' import { shareReplay, startWith } from 'rxjs/operators' - import Maximized from './Maximized.svelte' - import Minimized from './Minimized.svelte' - import Micro from './Micro.svelte' + import AccountCenterPanel from './AccountCenterPanel.svelte' + import TriggerLarge from './AcctCenterTriggerLarge.svelte' + import TriggerSmall from './AcctCenterTriggerSmall.svelte' const accountCenter$ = state .select('accountCenter') @@ -17,31 +17,21 @@ function minimize() { if ($accountCenter$.expanded) { updateAccountCenter({ expanded: false }) - visible=false + visible = false } } -{#if !$accountCenter$.minimal} -
- {#if $accountCenter$.position.includes('bottom')} - - {/if} - - - {#if $accountCenter$.position.includes('top')} - - {/if} -
-{:else if $accountCenter$.minimal} -
- +
{#if $accountCenter$.position.includes('bottom')} - + + {/if} + {#if $accountCenter$.minimal} + + {:else} + {/if} - {#if $accountCenter$.position.includes('top')} - + {/if} -
-{/if} +
From 0ab4f6d42987ecb76e76b48e3bd61d2a9b3d2db3 Mon Sep 17 00:00:00 2001 From: Kat Leight Date: Tue, 16 May 2023 10:30:31 -0600 Subject: [PATCH 07/14] remove unused variable --- packages/core/src/views/account-center/Index.svelte | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/core/src/views/account-center/Index.svelte b/packages/core/src/views/account-center/Index.svelte index 1aad411df..14ed7ab7e 100644 --- a/packages/core/src/views/account-center/Index.svelte +++ b/packages/core/src/views/account-center/Index.svelte @@ -12,12 +12,10 @@ .pipe(startWith(state.get().accountCenter), shareReplay(1)) onDestroy(minimize) - let visible = false function minimize() { if ($accountCenter$.expanded) { updateAccountCenter({ expanded: false }) - visible = false } } From 920b4e420430778866657c0b5ce43b57d9f66be3 Mon Sep 17 00:00:00 2001 From: Kat Leight Date: Tue, 16 May 2023 10:31:26 -0600 Subject: [PATCH 08/14] remove unused import --- .../core/src/views/account-center/AccountCenterPanel.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/views/account-center/AccountCenterPanel.svelte b/packages/core/src/views/account-center/AccountCenterPanel.svelte index 609b9be42..86fe175dd 100644 --- a/packages/core/src/views/account-center/AccountCenterPanel.svelte +++ b/packages/core/src/views/account-center/AccountCenterPanel.svelte @@ -1,7 +1,7 @@ +{#key $accountCenter$.position}
{#if $accountCenter$.position.includes('bottom')} @@ -33,3 +34,4 @@ {/if}
+{/key} From ea47dc37d32c48f3b63aa746fe4ec2fee7cdd0a7 Mon Sep 17 00:00:00 2001 From: Kat Leight Date: Wed, 17 May 2023 10:20:38 -0600 Subject: [PATCH 11/14] make key accountCenter --- packages/core/src/views/account-center/Index.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/views/account-center/Index.svelte b/packages/core/src/views/account-center/Index.svelte index 5bfad84bb..6ba068549 100644 --- a/packages/core/src/views/account-center/Index.svelte +++ b/packages/core/src/views/account-center/Index.svelte @@ -20,7 +20,7 @@ } -{#key $accountCenter$.position} +{#key $accountCenter$}
{#if $accountCenter$.position.includes('bottom')} From cac5d380d0204c3f5988bef5f5bc9985f43df2b4 Mon Sep 17 00:00:00 2001 From: Kat Leight Date: Wed, 17 May 2023 15:38:13 -0600 Subject: [PATCH 12/14] reenable off center click to minimize, fix duplicate issue --- packages/core/src/views/account-center/Index.svelte | 6 +++++- packages/demo/src/App.svelte | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/core/src/views/account-center/Index.svelte b/packages/core/src/views/account-center/Index.svelte index 6ba068549..ead09a185 100644 --- a/packages/core/src/views/account-center/Index.svelte +++ b/packages/core/src/views/account-center/Index.svelte @@ -20,7 +20,10 @@ } -{#key $accountCenter$} + + +{#key $accountCenter$.position} +{#key $accountCenter$.minimal}
{#if $accountCenter$.position.includes('bottom')} @@ -35,3 +38,4 @@ {/if}
{/key} +{/key} diff --git a/packages/demo/src/App.svelte b/packages/demo/src/App.svelte index 312dda530..39839e917 100644 --- a/packages/demo/src/App.svelte +++ b/packages/demo/src/App.svelte @@ -310,9 +310,9 @@ // // example customizing account center accountCenter: { desktop: { - position: 'topRight', + position: 'topLeft', enabled: true, - minimal: false + minimal: true } }, // example customizing copy From 4677255b4491f661dca413137d48acef56154c17 Mon Sep 17 00:00:00 2001 From: Kat Leight Date: Thu, 18 May 2023 11:10:47 -0600 Subject: [PATCH 13/14] add warning about default position change --- .../docs/[...3]modules/[...1]core/+page.md | 16 ++++++++++++++++ packages/core/README.md | 14 ++++++++++++++ 2 files changed, 30 insertions(+) diff --git a/docs/src/routes/docs/[...3]modules/[...1]core/+page.md b/docs/src/routes/docs/[...3]modules/[...1]core/+page.md index dcd637d50..6744f4e95 100644 --- a/docs/src/routes/docs/[...3]modules/[...1]core/+page.md +++ b/docs/src/routes/docs/[...3]modules/[...1]core/+page.md @@ -17,6 +17,22 @@ title: Core This is the core package that contains all of the UI and logic to be able to seamlessly connect user's wallets to your app and track the state of those wallets. Onboard no longer contains any wallet specific code, so wallets need to be passed in upon initialization. +:::admonition type="warning" +_note: Release 2.23.0 moves the default position of the account center from topRight to bottomRight. To reset your application to topRight, include the following when initializing onboard:_ +```typescript + accountCenter: { + desktop: { + enabled: true, + position: 'topRight' + }, + mobile: { + enabled: true, + position: 'topRight' + } + } +``` +::: + ## Install Install the core module: diff --git a/packages/core/README.md b/packages/core/README.md index c641a8431..2186595b3 100644 --- a/packages/core/README.md +++ b/packages/core/README.md @@ -6,6 +6,20 @@ This is the core package that contains all of the UI and logic to be able to seamlessly connect user's wallets to your app and track the state of those wallets. Onboard no longer contains any wallet specific code, so wallets need to be passed in upon initialization. +_Warning: Release 2.23.0 moves the default position of the account center from topRight to bottomRight. To reset your application to topRight, include the following when initializing onboard:_ +```typescript + accountCenter: { + desktop: { + enabled: true, + position: 'topRight' + }, + mobile: { + enabled: true, + position: 'topRight' + } + } +``` + ## Quick start Checkout our full library of quick start examples for connecting and interacting with EVM based wallets From 0736f3aba20a869951f72405d1658fbb8b9cc725 Mon Sep 17 00:00:00 2001 From: Kat Leight Date: Thu, 18 May 2023 11:21:07 -0600 Subject: [PATCH 14/14] change warning to tip --- docs/src/routes/docs/[...3]modules/[...1]core/+page.md | 2 +- packages/core/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/src/routes/docs/[...3]modules/[...1]core/+page.md b/docs/src/routes/docs/[...3]modules/[...1]core/+page.md index 6744f4e95..a2cf00779 100644 --- a/docs/src/routes/docs/[...3]modules/[...1]core/+page.md +++ b/docs/src/routes/docs/[...3]modules/[...1]core/+page.md @@ -17,7 +17,7 @@ title: Core This is the core package that contains all of the UI and logic to be able to seamlessly connect user's wallets to your app and track the state of those wallets. Onboard no longer contains any wallet specific code, so wallets need to be passed in upon initialization. -:::admonition type="warning" +:::admonition type="tip" _note: Release 2.23.0 moves the default position of the account center from topRight to bottomRight. To reset your application to topRight, include the following when initializing onboard:_ ```typescript accountCenter: { diff --git a/packages/core/README.md b/packages/core/README.md index 2186595b3..952822193 100644 --- a/packages/core/README.md +++ b/packages/core/README.md @@ -6,7 +6,7 @@ This is the core package that contains all of the UI and logic to be able to seamlessly connect user's wallets to your app and track the state of those wallets. Onboard no longer contains any wallet specific code, so wallets need to be passed in upon initialization. -_Warning: Release 2.23.0 moves the default position of the account center from topRight to bottomRight. To reset your application to topRight, include the following when initializing onboard:_ +_Tip: Release 2.23.0 moves the default position of the account center from topRight to bottomRight. To reset your application to topRight, include the following when initializing onboard:_ ```typescript accountCenter: { desktop: {