Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add support for wallet_switchEthereumChain in the walletConnect provider #1313

Closed
alexkeating opened this issue Oct 8, 2022 · 7 comments · Fixed by #1363
Closed
Assignees
Labels
feature New feature or request

Comments

@alexkeating
Copy link

Is your request related to a problem?

  • When a user connects to our app with walletconnect we want to be able to switch the chain they are connected to in our app.

Feature Description

Implement wallet_switchEthereumChain in the below provider. My guess is that the wallet connect session could be updated to the passed in chainId.

Alternative Solutions

No response

Anything else?

No response

@lnbc1QWFyb24
Copy link
Contributor

@alexkeating we will take a look in to this and see if can get a workaround like recreating the session to make it work.

@alexkeating
Copy link
Author

Great, thank you!

@alexkeating
Copy link
Author

Any updates on this? Anything I can do to help move this along?

@lnbc1QWFyb24
Copy link
Contributor

Hey @alexkeating sorry we have a lot in our backlog at the moment, so have not had a chance to get to this yet. You can try and work out a solution and create a PR if you have time which will speed up the process as we would only need to review in that case.

@alexkeating
Copy link
Author

alexkeating commented Nov 27, 2022

I am upgrading Umbra to the latest version of the web3-onboard wallet connect package, and it doesn't seem to be switching when wallet_switchEthereumChain is sent. I am not sure why yet, but I thought it would be good to surface, and I am wondering if you guys are seeing the same thing locally.

@Adamj1232
Copy link
Member

@alexkeating I have a PR open that you can track that issue here
Should have an alpha fix available shortly

@Adamj1232
Copy link
Member

Adamj1232 commented Nov 28, 2022

@alexkeating an alpha version of this fix has been published and you can try the alpha release of the WalletConnect package at version 2.2.1-alpha.1 which you can find here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment