[Bug]: JSON config breaks #16840
Replies: 2 comments 8 replies
-
|
I proceeded to try fixing the JSON config and running it without config migration and it still fails. So perhaps the initial title is bad and it's not related to migration. However, something is wrong with the use of JSON config just after the migration step. I'd still expect the migration to produce JSON with quoted keys and string values. {
"mqtt": {
"enabled": false
},
"cameras": {
"dummy_camera": {
"enabled": false,
"ffmpeg": {
"inputs": [
{
"path": "rtsp://127.0.0.1:554/rtsp",
"roles": [
"detect"
]
}
]
}
}
},
"version": "0.15-1"
} |
Beta Was this translation helpful? Give feedback.
-
|
Frigate's config parser expects YAML, not JSON. Where did you see that JSON was a valid config format? |
Beta Was this translation helpful? Give feedback.
-
|
Yeah that definitely doesn't, but there is code to handle json /~https://github.com/blakeblackshear/frigate/blob/dev/frigate%2Fconfig%2Fconfig.py#L703 |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for your responses so far. JSON has worked for many months at least with support in the code to handle such config. If the project has decided to depreciate JSON support then I will move to YAML. However, I've not seen that mentioned on the release pages and the code still exists to look for a JSON config. If it's not deprecated then the bug still stands, Frigate is both malforming JSON configs, and failing to start when they're used. |
Beta Was this translation helpful? Give feedback.
-
|
Personally, I manage my config externally so do not make use of the UI code editor etc. |
Beta Was this translation helpful? Give feedback.
-
|
Though there may be a code path for it and though it has been functional for you in the past, there has never been any official support for json. The docs exclusively mention yaml as the config format. And to be clear, there are features in the UI that write back to the config file - something completely separate from the UI's config editor. I don't think it makes sense to write code to fully support json moving forward, but I'd be curious to see if the other maintainers have thoughts. |
Beta Was this translation helpful? Give feedback.
-
|
while we've never had official support for json, we've always done our best to support the use case of users that have read only configurations. In general I believe the recommendation is to have a read only yaml file, though I am confused why the JSON stopped working here |
Beta Was this translation helpful? Give feedback.
-
Checklist
Describe the problem you are having
When using a config.json file the config file is mangled and the container stops.
Steps to reproduce
Version
0.15.0
In which browser(s) are you experiencing the issue with?
No response
Frigate config file
docker-compose file or Docker CLI command
Relevant Frigate log output
Relevant go2rtc log output
go2rtc logs were not split on container output and I don't think it's a go2rtc issue.Operating system
Other Linux
Install method
Docker CLI
Network connection
Wired
Camera make and model
NA
Screenshots of the Frigate UI's System metrics pages
No UI
Any other information that may be helpful
It works if I try it with a YAML config. The conversion adds
version: 0.15-1to it. The JSON attempt produces this:I manage the config with NixOS which generates a config.json file which is then read only. I would prefer the output to tell me what config I need to update in addition to trying to update it, so that I can perform the changes manually in my NixOS config. NixOS has a
environment.etc."frigate/config.json".text = builtins.toJSON {..config..}but no toYAML function.Beta Was this translation helpful? Give feedback.
All reactions