Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests take too long to run #249

Closed
rlouf opened this issue Jul 6, 2022 · 2 comments · Fixed by #279
Closed

Tests take too long to run #249

rlouf opened this issue Jul 6, 2022 · 2 comments · Fixed by #279
Labels
enhancement New feature or request refactoring Change that adds no functionality but improves code quality

Comments

@rlouf
Copy link
Member

rlouf commented Jul 6, 2022

The full test suite currently takes > 10 mins to run, mainly because of the tests for the SMC algorithms. We should aim to bring this down under two minutes.
@rlouf rlouf added enhancement New feature or request refactoring Change that adds no functionality but improves code quality labels Jul 6, 2022
@rlouf
Copy link
Member Author

rlouf commented Sep 19, 2022

I general I don't like the "test by example" approach that we've been taking so far. Unless we're testing against examples for which we have theoretical results on convergence, tests are doing a lot of work for little added value. Integration tests don't require taking a thousand samples.

@rlouf
Copy link
Member Author

rlouf commented Oct 24, 2022

I am simplifying the tests in #279; SMC is where the test suite currently spend the largest amount of time.

@rlouf rlouf linked a pull request Jan 13, 2023 that will close this issue
Refactor the SMC kernels #279
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactoring Change that adds no functionality but improves code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor the SMC kernels rlouf/blackjax
1 participant
@rlouf