You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That method is to complex and does to many things for a "simple" config setter. We need to find a solution to decouple/isolate that code somehow.
The reason is I do have two big PRs that are blocked because of that one method. One is PR #1850 (replace class Config with a new one) and the other is PR #1865 (heavy refactoring of the Manage Profiles dialog).
The text was updated successfully, but these errors were encountered:
Refactoring of the Daemon class in tools.py and separating it into its own file.
The license situation is cleared after contacting its original author. Details in the modules docstring.
Comprehensive and complex refactoring and also code moving.
The method Config.setSnapshotsPaths() has to much logic in it, not belonging in that method nor into its class. Code was extracted and "parked" in the tools.py module. This in consequences gives the ability to easier decouple code in SettingsDialog.saveProfile() (PR #1865).
Prepares for a new config management class (PR #1850) and refactoring the manage profiles dialog (PR #1865).
Close#1864
This is about
common/config.py::Config.setSnapshotsPath()
.backintime/common/config.py
Line 440 in 8c7afef
That method is to complex and does to many things for a "simple" config setter. We need to find a solution to decouple/isolate that code somehow.
The reason is I do have two big PRs that are blocked because of that one method. One is PR #1850 (replace
class Config
with a new one) and the other is PR #1865 (heavy refactoring of the Manage Profiles dialog).The text was updated successfully, but these errors were encountered: