diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index efe75154..ae0ffbf0 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,12 +1,12 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2024-01-31 10:36:31 UTC using RuboCop version 1.60.2. +# on 2024-03-08 10:11:27 UTC using RuboCop version 1.62.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 13 +# Offense count: 14 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: with_first_argument, with_fixed_indentation @@ -32,13 +32,6 @@ Layout/EmptyLineAfterGuardClause: - 'app/models/hiera_data/config.rb' - 'app/models/hiera_data/yaml_file.rb' -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EmptyLineBetweenMethodDefs, EmptyLineBetweenClassDefs, EmptyLineBetweenModuleDefs, DefLikeMacros, AllowAdjacentOneLineDefs, NumberOfEmptyLines. -Layout/EmptyLineBetweenDefs: - Exclude: - - 'test/models/hiera_data/config_test.rb' - # Offense count: 2 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. @@ -71,16 +64,6 @@ Layout/FirstArrayElementIndentation: Exclude: - 'test/models/hiera_data_test.rb' -# Offense count: 5 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle. -# SupportedHashRocketStyles: key, separator, table -# SupportedColonStyles: key, separator, table -# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit -Layout/HashAlignment: - Exclude: - - 'test/models/key_test.rb' - # Offense count: 1 # This cop supports safe autocorrection (--autocorrect). Layout/HeredocIndentation: @@ -96,7 +79,7 @@ Layout/IndentationConsistency: - 'app/controllers/users_controller.rb' - 'test/models/hiera_data/yaml_file_test.rb' -# Offense count: 4 +# Offense count: 19 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: Width, AllowedPatterns. Layout/IndentationWidth: @@ -125,7 +108,7 @@ Layout/SpaceAroundOperators: - 'test/models/hiera_data/yaml_file_test.rb' - 'test/models/hiera_data_test.rb' -# Offense count: 55 +# Offense count: 43 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space, compact @@ -136,7 +119,6 @@ Layout/SpaceInsideHashLiteralBraces: - 'test/models/hiera_data/interpolation_test.rb' - 'test/models/hiera_data/yaml_file_test.rb' - 'test/models/hiera_data_test.rb' - - 'test/models/key_test.rb' # Offense count: 1 # This cop supports safe autocorrection (--autocorrect). @@ -171,13 +153,6 @@ Lint/ScriptPermission: Exclude: - 'test/fixtures/files/puppet/environments/eyaml/generate_eyaml_entries.rb' -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments. -Lint/UnusedBlockArgument: - Exclude: - - 'app/models/key.rb' - # Offense count: 8 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. Metrics/AbcSize: @@ -188,7 +163,7 @@ Metrics/AbcSize: Metrics/CyclomaticComplexity: Max: 8 -# Offense count: 17 +# Offense count: 18 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: Max: 17 @@ -238,6 +213,17 @@ Rails/ReversibleMigration: Exclude: - 'db/migrate/20210326144242_drop_puppet_tables.rb' +# Offense count: 4 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowOnlyRestArgument, UseAnonymousForwarding, RedundantRestArgumentNames, RedundantKeywordRestArgumentNames, RedundantBlockArgumentNames. +# RedundantRestArgumentNames: args, arguments +# RedundantKeywordRestArgumentNames: kwargs, options, opts +# RedundantBlockArgumentNames: blk, block, proc +Style/ArgumentsForwarding: + Exclude: + - 'test/controllers/ldap_sessions_controller_test.rb' + - 'test/controllers/saml_sessions_controller_test.rb' + # Offense count: 1 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, AllowBracesOnProceduralOneLiners, BracesRequiredMethods. @@ -249,7 +235,7 @@ Style/BlockDelimiters: Exclude: - 'test/fixtures/files/puppet/environments/eyaml/generate_eyaml_entries.rb' -# Offense count: 12 +# Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: nested, compact @@ -265,7 +251,7 @@ Style/CommandLiteral: Exclude: - 'test/fixtures/files/puppet/environments/eyaml/generate_eyaml_entries.rb' -# Offense count: 68 +# Offense count: 72 # Configuration parameters: AllowedConstants. Style/Documentation: Enabled: false @@ -278,7 +264,7 @@ Style/Documentation: Style/FormatStringToken: EnforcedStyle: template -# Offense count: 142 +# Offense count: 150 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never @@ -340,7 +326,7 @@ Style/PreferredHashMethods: - 'app/models/hiera_data/yaml_file.rb' # Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle, AllowedCompactTypes. # SupportedStyles: compact, exploded Style/RaiseArgs: @@ -377,7 +363,7 @@ Style/SafeNavigation: Exclude: - 'app/controllers/sessions_controller.rb' -# Offense count: 996 +# Offense count: 1092 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes @@ -397,7 +383,7 @@ Style/ZeroLengthPredicate: Exclude: - 'test/fixtures/files/puppet/environments/eyaml/generate_eyaml_entries.rb' -# Offense count: 30 +# Offense count: 31 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. # URISchemes: http, https diff --git a/Gemfile b/Gemfile index 49b22607..10e25a30 100644 --- a/Gemfile +++ b/Gemfile @@ -60,7 +60,7 @@ group :test do end group :linter do - gem 'rubocop', '~> 1.60.2' + gem 'rubocop', '~> 1.62.0' gem 'rubocop-capybara', '~> 2.20.0' gem 'rubocop-performance', '~> 1.20.2' gem 'rubocop-rails', '~> 2.24.0' diff --git a/Gemfile.lock b/Gemfile.lock index 52adc5a1..cd98808a 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -363,7 +363,7 @@ GEM actionpack (>= 5.2.0) rspec-core rspec-support (3.13.1) - rubocop (1.60.2) + rubocop (1.62.0) json (~> 2.3) language_server-protocol (>= 3.17.0) parallel (~> 1.10) @@ -371,7 +371,7 @@ GEM rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.8, < 3.0) rexml (>= 3.2.5, < 4.0) - rubocop-ast (>= 1.30.0, < 2.0) + rubocop-ast (>= 1.31.1, < 2.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 2.4.0, < 3.0) rubocop-ast (1.31.1)