feat: initial implementation of showing clustered responses #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpf500
force-pushed
the
feat/1247-overlapping-responses
branch
from
3f48dad to
5c5f7f3
Compare
JumpLink
approved these changes
Jan 14, 2025
|
|
||
| const source = map.value.getSource('responses') as GeoJSONSource; | ||
| source.getClusterExpansionZoom(cluster.properties.cluster_id, (err, zoom) => { | ||
| if (err || zoom == null) return; |
There was a problem hiding this comment.
Maybe adding error logging here like this?
if (err || zoom == null) {
console.error('Failed to get cluster expansion zoom:', err);
return;
}| if (!map.value) return; | ||
|
|
||
| const feature = map.value.queryRenderedFeatures({ | ||
| layers: ['unclustered-points', 'clusters'], |
There was a problem hiding this comment.
Move magic strings to constants:
const LAYER_IDS = {
CLUSTERS: 'clusters',
UNCLUSTERED_POINTS: 'unclustered-points',
SELECTED_RESPONSE: 'selected-response'
} as const;| .map(Number) | ||
| .sort(); | ||
|
|
||
| return responses.value.filter((r) => responseNumbers.includes(r.number)); |
There was a problem hiding this comment.
My coding assistant suggests a performance optimization here. Your current implementation has a complexity of O(n) lookup, but you can use Map for O(1) lookups:
const responseMap = new Map(responses.value.map(r => [r.number, r]));
const selectedResponses = responseNumbers.map(n => responseMap.get(n)).filter(Boolean);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to see clusters of responses on the Atlas. Previously if multiple responses were too close together you could only see one of them.
This feature respects the Atlas max zoom setting which allows admins to control the maximum "declustering" zoom point. Previously it was hard coded that all clusters disappeared at a certain zoom level because you could only see responses on their own, not in a cluster.