(DeathKnight): Unholy Gargoyle scaling spells unimplemented.

[heyitsbench]

Current Behaviour

Currently there is a hunter pet scaling spell enumerated in the DK pet script under the name SPELL_DK_PET_SCALING, but it goes unused in the script itself.

Expected Blizzlike Behaviour

Gargoyle (and other pets) should have a few auras on them that affect quite a few things. For the gargoyle, that includes the following: Death Knight Pet Scaling 01, Death Knight Pet Scaling 02, and Death Knight Pet Scaling 03.

Source

Sniffs, both Wrath Classic/Wrath retail

Steps to reproduce the problem

1. Create a Death Knight.
2. .levelup 25
3. Accrue the talents required to engage in gargoylery.
4. Summon the gargoyle you worked so hard for.
5. .list auras on said gargoyle.
6. Observe none of the aforementioned.

Extra Notes

These types of auras extend beyond the gargoyle and even beyond just the Death Knight, a lot of information on these can be found in these two TC issues: TrinityCore/TrinityCore#874, TrinityCore/TrinityCore#5136. Reason I'm reporting the gargoyle in particular (first, at least) is because it is apparently one of the ones people complain about most for not having well scaling with the summoner's haste, which seems to be handled through these spells.

AC rev. hash/commit

fdbde0b

Operating system

Windows 10 x64

Custom changes or Modules

mod-ptr-template

[Kitzunu]

what about

azerothcore-wotlk/src/server/game/Entities/Pet/Pet.cpp

Lines 1343 to 1356 in a1891d8

	case NPC_EBON_GARGOYLE: // Ebon Gargoyle
	{
	if (!pInfo)
	{
	SetCreateMana(28 + 10 * petlevel);
	SetCreateHealth(28 + 30 * petlevel);
	}
	AddAura(SPELL_HUNTER_PET_SCALING_04, this);
	AddAura(SPELL_DK_PET_SCALING_01, this);
	AddAura(SPELL_DK_PET_SCALING_02, this);
	AddAura(SPELL_DK_PET_SCALING_03, this);
	break;
	}

[Kitzunu]

Handled here

azerothcore-wotlk/src/server/scripts/Spells/spell_dk.cpp

Lines 726 to 729 in a1891d8

	/* 51996 - Death Knight Pet Scaling 02
	54566 - Death Knight Pet Scaling 01
	61697 - Death Knight Pet Scaling 03 */
	class spell_dk_pet_scaling : public AuraScript

[Joshmash]

so when will these changes be applied?

[Kitzunu]

They already exist

[heyitsbench]

what about [Pet.cpp]
Handled here [spell_dk.cpp]

My mistake, I believe I was checking the pet_dk script file for it. Either way, I don't believe Hunter Pet Scaling 04 should be applied to Gargoyles. Based on discussions I've had with players on CC, the formula for some of these scaling spells may also be incorrect, hence why I opened this issue, but this issue itself is invalid. Thanks for checking.