Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MD5 hashing to a Data extension and return Data type directly + rename all checksum functions with compute prefix #222

Closed
2 tasks
dayaffe opened this issue Jan 9, 2024 · 1 comment · Fixed by #221
Assignees
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@dayaffe
Copy link
Contributor

dayaffe commented Jan 9, 2024

Describe the feature

  • Make the MD5 algorithm a Data extension
  • Remove the call to base64 encoding
  • Rename algorithms to add compute prefix

Use Case

Having the MD5 algorithm as a String extension can lead to issues as it would requires encoding request payloads to utf8 when there is no such restriction. Additionally, adding a base64 encoding limits usage in the SDK when we may not always want the result encoded that way.

Proposed Solution

As state above in feature description.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@dayaffe dayaffe added needs-triage This issue or PR still needs to be triaged. feature-request A feature should be added or improved. labels Jan 9, 2024
@dayaffe dayaffe linked a pull request Jan 9, 2024 that will close this issue
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants