codegen: Update PresignClient to default use signer and options #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
reviewed
Dec 11, 2020
jasdel
force-pushed
the
fixup/SigNotMatch
branch
from
684a76b to
a97c37b
Compare
3 tasks
jasdel
force-pushed
the
fixup/SigNotMatch
branch
from
a97c37b to
d7f6815
Compare
skotambkar
approved these changes
Dec 12, 2020
Updates the PresignClient generation to use the same Signer initialization as the API client. In addition, the PresignClient was updated to ensure the PresignOptions are passed down and used at each level.
jasdel
force-pushed
the
fixup/SigNotMatch
branch
from
d7f6815 to
4a45915
Compare
jasdel
force-pushed
the
fixup/SigNotMatch
branch
from
4a45915 to
31fe72f
Compare
skotambkar
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the PresignClient generation to use the same Signer initialization as the API client. In addition, the PresignClient was updated to ensure the PresignOptions are passed down and used at each level.
Change updates the PresignClient and API client to use the same
v4.Signerinitialization if a (pre)signer has not been configured. Also updates the PresignClient to have PresignOption as a member instead of separate fields similar to API client's design. This allows the presign client to more easily pass down its configuration and be modified on a per operation base.All changes to
aws/signer/v4are because this change is based on, #964, and will rebased once that that PR is merged.presigner: Remove content-type header if empty/nil body for streaming operation #967 after that PR is merged.Fixes #952