Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML-KEM clean up #2002

Open
jakemas opened this issue Nov 19, 2024 · 1 comment
Open

ML-KEM clean up #2002

jakemas opened this issue Nov 19, 2024 · 1 comment

Comments

@jakemas
Copy link
Contributor

jakemas commented Nov 19, 2024

I've been tracking some inconsistencies with ML-KEM that possibly need clean up:

  • rename internal functions from deterministic to internal for more clarity with standard
  • remove unnecessary KYBER_NAMESPACE that remains
  • update function documentation for input arguments (e.g. ml_kem_params)
  • use of both secret/private inconsistencies
@jakemas
Copy link
Contributor Author

jakemas commented Feb 24, 2025

As of: https://csrc.nist.gov/Projects/post-quantum-cryptography/faqs#Rdc7 NIST now allow ML-KEM seeds to be imported/exported as seeds. As such, NIST have allowed the use of _internal keygen functions (previously these functions were only allowed to be exposed for testing purposes).

As such, exposing internal functions is now a should and not must (https://groups.google.com/a/list.nist.gov/g/pqc-forum/c/949fsZRC6Ik/m/Z8KsHs8iBQAJ) so we can take the functions from evp/experimental/ and make them all stable APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant