-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for portrait videos #28
Comments
thanks for your feedback, we will add this request to our features roadmap and review it in the next release. |
We need this as soon as possible please. We are really struggling and we are live. |
@RealDrewKlayman If you are willing to help test, you can checkout my fork. I wouldn't deploy to production until you're comfortable with how it behaves. |
@arivera-skycred Hi, I'm trying it and it doesn't update my job templates. |
@romcok I am not sure if it will work in an update scenario. I tore down the entire CloudFormation deployment and tried from scratch and it worked. The only issue I noticed was with the Encode lambda function. For some reason the Layer that is added during the CloudFormation is not properly utlizing the latest See this for more help with that: https://stackoverflow.com/a/53786393/210039 |
Uf, thanks, but this is little hard to update. Do you know where mediaInfo.video[0].rotation comes from? I don't see it in srcMediaInfo. I think it set me the landscape video to portrait because the rotation property is missing.
|
Finally it works. |
@romcok glad it works for you now. It was a tedious update to be sure. |
We just released a new version of the solution (v5.0.0 - https://aws.amazon.com/solutions/video-on-demand-on-aws/), and thanks to this PR by @rromanchuk (#27), you can now specify an inputRotate parameter to the workflow (/~https://github.com/awslabs/video-on-demand-on-aws#source-metadata-option). |
Please add support for videos shot in portrait resolutions.
The text was updated successfully, but these errors were encountered: