Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for portrait videos #28

Closed
arivera-skycred opened this issue Jun 5, 2019 · 9 comments
Closed

Add support for portrait videos #28

arivera-skycred opened this issue Jun 5, 2019 · 9 comments

Comments

@arivera-skycred
Copy link

arivera-skycred commented Jun 5, 2019

Please add support for videos shot in portrait resolutions.

  • Include MediaConvert templates for portrait resolutions
  • Include support for Rotate parameter
@tomnight
Copy link
Contributor

tomnight commented Jun 6, 2019

thanks for your feedback, we will add this request to our features roadmap and review it in the next release.

@RealDrewKlayman
Copy link

We need this as soon as possible please. We are really struggling and we are live.

@arivera-skycred
Copy link
Author

@RealDrewKlayman If you are willing to help test, you can checkout my fork. I wouldn't deploy to production until you're comfortable with how it behaves.

/~https://github.com/arivera-skycred/video-on-demand-on-aws

#29

@romcok
Copy link

romcok commented Jun 13, 2019

@arivera-skycred Hi, I'm trying it and it doesn't update my job templates.

@arivera-skycred
Copy link
Author

arivera-skycred commented Jun 13, 2019

@romcok I am not sure if it will work in an update scenario. I tore down the entire CloudFormation deployment and tried from scratch and it worked. The only issue I noticed was with the Encode lambda function. For some reason the Layer that is added during the CloudFormation is not properly utlizing the latest aws-sdk which is required for the Rotate: AUTO param to work. I had to manually upload the layer for it to work.

See this for more help with that: https://stackoverflow.com/a/53786393/210039

@romcok
Copy link

romcok commented Jun 13, 2019

Uf, thanks, but this is little hard to update.

Do you know where mediaInfo.video[0].rotation comes from? I don't see it in srcMediaInfo. I think it set me the landscape video to portrait because the rotation property is missing.

event.rotation = mediaInfo.video[0].rotation; // == undefined

event.isRotated = (event.rotation !== 0 && event.rotation !== 180); // == true

@romcok
Copy link

romcok commented Jun 17, 2019

Finally it works.
I had to map the rotation attribute to MediaInfo class and change cf custom resource.

@arivera-skycred
Copy link
Author

@romcok glad it works for you now. It was a tedious update to be sure.

@dscpinheiro
Copy link

We just released a new version of the solution (v5.0.0 - https://aws.amazon.com/solutions/video-on-demand-on-aws/), and thanks to this PR by @rromanchuk (#27), you can now specify an inputRotate parameter to the workflow (/~https://github.com/awslabs/video-on-demand-on-aws#source-metadata-option).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants