Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a claim near to the Logo on the cover-page. #825

Closed
jmini opened this issue Jun 13, 2017 · 4 comments
Closed

Add a claim near to the Logo on the cover-page. #825

jmini opened this issue Jun 13, 2017 · 4 comments
Milestone

Comments

@jmini
Copy link

jmini commented Jun 13, 2017

We would like to add a claim next to the logo on the cover-page. In my example:

© The H company, {YEAR}

Preview:

claim

@mojavelinux
Copy link
Member

This is something I strongly recommend adding to the background image. One way to make that dynamic is to make the background image an SVG so that you can easily write text into it in a pre-generate step.

Another idea is to use the title logo to insert this graphic, which would be possible once #431 is implemented.

Aside from a background or title logo, I don't think design elements should be handled by the theme.

jmini added a commit to jmini/asciidoctor-maven-examples that referenced this issue Jun 16, 2017
@jmini
Copy link
Author

jmini commented Jun 16, 2017

The idea to use svg for the logo and to customize it during the build is great. I have tried it (see commit 9d7bc68). The output looks like this:

logo with claim

I am wondering if there is any kind of limitation, because the original svg image looks like this:

Preview of logo.svg

@AlexanderZobkov
Copy link
Contributor

AlexanderZobkov commented Jun 24, 2017

asciidoctor-pdf uses prawn-svg under the hood to render SVG images. it might just not support svg capabilies used in your svg image. I can suggest the following:

  • Look inside your svg image and try to identify what SVG elements are used for these incorrectly rendered parts (Inkscape can help you)
  • Replace them with SVG elements that are supported by prawn-svg
  • If nothing helps submit an issue for prawn-svg

@mojavelinux mojavelinux added this to the support milestone Nov 26, 2018
@mojavelinux
Copy link
Member

The font used in the SVG has to match a font loaded in your theme. That's why it looks visually different. prawn-svg picks up any fonts loaded in Prawn (by way of the Asciidoctor PDF theme file). This is the same requirement anytime you use an SVG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants