Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported content type when multipart chunk content-type contains anything more than just the type #3495

Closed
calvincestari opened this issue Jan 6, 2025 · 1 comment · Fixed by apollographql/apollo-ios-dev#572
Assignees
Labels
bug Generally incorrect behavior networking-stack

Comments

@calvincestari
Copy link
Member

Summary

Copied from #2395 (comment).

Based on the defer spec here, an example response body could look like the following:

/~https://github.com/graphql/graphql-over-http/blob/main/rfcs/IncrementalDelivery.md#content-type-multipartmixed

---
Content-Type: application/json; charset=utf-8

{"data":{"hello":"Hello Rob"},"hasNext":true}
---
Content-Type: application/json; charset=utf-8

{"data":{"test":"Hello World"},"path":[],"hasNext":false}
-----

As of right now, the code is only checking for
Content-Type to be application/json. This seems to cause problems and throws an unsupportedType error.

Version

1.15.3

Steps to reproduce the behavior

Receive a multipart chunk with a content type of Content-Type: application/json; charset=utf-8.

Logs

No response

Anything else?

No response

@calvincestari
Copy link
Member Author

@brettephillips - the fix for this has been merged and will go out in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Generally incorrect behavior networking-stack
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant