Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Promote Desugarer to be the first preprocessing pass #531

Closed
konnov opened this issue Feb 1, 2021 · 0 comments
Closed

[FEATURE] Promote Desugarer to be the first preprocessing pass #531

konnov opened this issue Feb 1, 2021 · 0 comments
Assignees
@konnov
Labels
Fprepro Feature: TLA+ preprocessor FTC-Snowcat Feature: Fully-functional type checker Snowcat new New issue to be triaged. refactoring
Milestone
Typechecker Snowcat

Comments

@konnov
Copy link
Collaborator

konnov commented Feb 1, 2021

Desugarer helps us to get rid of the nasty syntax sugar in TLA+. For the moment, it is working on flat TLA+, that is, when calls to user-defined operators are inlined. As a result, we have #528. Also, we cannot use Desugarer in the type checker, so we have #482.

We should refactor Desugarer to work with arbitrary TLA+ expressions, including calls to user-defined operators. Then we can reorder the passes to call Desugarer first.
@konnov konnov added new New issue to be triaged. refactoring labels Feb 1, 2021
@konnov konnov added this to the February iteration milestone Feb 1, 2021
@konnov konnov self-assigned this Feb 1, 2021
This was referenced Feb 1, 2021
Closed
Closed
@konnov konnov added FTC-Snowcat Feature: Fully-functional type checker Snowcat Fprepro Feature: TLA+ preprocessor labels Feb 1, 2021
konnov added a commit that referenced this issue Feb 2, 2021
@konnov
failing test to reproduce #531
e8e856f
konnov added a commit that referenced this issue Feb 2, 2021
@konnov
close #531
af05e6b
@konnov konnov mentioned this issue Feb 2, 2021
Merged
4 tasks
@konnov konnov closed this as completed Feb 3, 2021
konnov added a commit that referenced this issue Feb 3, 2021
@konnov
Promote Desugarer to be the first pass (#536)
f9cd507 
closes #531
This was referenced Feb 8, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konnov konnov

Labels
Fprepro Feature: TLA+ preprocessor FTC-Snowcat Feature: Fully-functional type checker Snowcat new New issue to be triaged. refactoring
Projects
None yet
Milestone
Typechecker Snowcat
Development

No branches or pull requests
1 participant
@konnov