From 9ea64b90a61b1e3f888d2bf18828acdd2f4c874a Mon Sep 17 00:00:00 2001 From: YorkShen Date: Fri, 2 Aug 2019 16:06:09 +0800 Subject: [PATCH] [Android] Add some annotation to suppress android lint. (#2779) --- .../java/com/taobao/weex/ui/component/WXComponent.java | 1 + .../java/com/taobao/weex/ui/component/WXSlider.java | 2 ++ .../weex/ui/component/list/BasicListComponent.java | 1 + .../ui/component/pesudo/TouchActivePseudoListener.java | 2 ++ .../weex/ui/component/richtext/WXRichTextView.java | 2 ++ .../com/taobao/weex/ui/view/WXCircleViewPager.java | 1 + .../main/java/com/taobao/weex/ui/view/WXEditText.java | 1 + .../taobao/weex/ui/view/WXHorizontalScrollView.java | 2 ++ .../main/java/com/taobao/weex/ui/view/WXImageView.java | 4 +--- .../java/com/taobao/weex/ui/view/WXScrollView.java | 1 + .../java/com/taobao/weex/ui/view/WXSwitchView.java | 2 ++ .../main/java/com/taobao/weex/ui/view/WXTextView.java | 5 ++--- .../main/java/com/taobao/weex/ui/view/WXVideoView.java | 1 + .../com/taobao/weex/ui/view/gesture/WXGesture.java | 10 +++++----- .../taobao/weex/ui/view/listview/WXRecyclerView.java | 2 ++ .../java/com/taobao/weex/utils/WXSoInstallMgrSdk.java | 2 ++ 16 files changed, 28 insertions(+), 11 deletions(-) diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java index 7d4fdcbef7..e7be2ff6d4 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java @@ -1680,6 +1680,7 @@ private Drawable prepareBackgroundRipple() { new int[]{rippleColor}); return new RippleDrawable(colorStateList, new ColorDrawable(colorInt), null) { @Override + @SuppressLint("CanvasSize") public void draw(@NonNull Canvas canvas) { if (mBackgroundDrawable != null) { Path border = mBackgroundDrawable.getContentPath(new RectF(0, 0, canvas.getWidth(), canvas.getHeight())); diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java index 6a91644486..c2806fadf7 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java @@ -18,6 +18,7 @@ */ package com.taobao.weex.ui.component; +import android.annotation.SuppressLint; import android.content.Context; import android.support.annotation.NonNull; import android.support.v4.view.ViewPager; @@ -554,6 +555,7 @@ public void onPageScrollStateChanged(int state) { } } + @SuppressLint("ClickableViewAccessibility") private void hackTwoItemsInfiniteScroll() { if (mViewPager == null || mAdapter == null) { return; diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java index 3eeeb573e5..eba3b3fea5 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java @@ -939,6 +939,7 @@ public void onBindViewHolder(final ListBaseViewHolder holder, int position) { if (anchorComponent != null && anchorComponent.getHostView() != null && !isExcluded) { View anchor = anchorComponent.getHostView(); anchor.setOnTouchListener(new View.OnTouchListener() { + @SuppressLint("ClickableViewAccessibility") @Override public boolean onTouch(View v, MotionEvent event) { if (MotionEventCompat.getActionMasked(event) == MotionEvent.ACTION_DOWN) { diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/pesudo/TouchActivePseudoListener.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/pesudo/TouchActivePseudoListener.java index 8caf3f2290..1834675069 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/component/pesudo/TouchActivePseudoListener.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/pesudo/TouchActivePseudoListener.java @@ -18,6 +18,7 @@ */ package com.taobao.weex.ui.component.pesudo; +import android.annotation.SuppressLint; import android.view.MotionEvent; import android.view.View; @@ -33,6 +34,7 @@ public TouchActivePseudoListener(OnActivePseudoListner l, boolean consumeInTouch mIsConsumeOnTouch = consumeInTouch; } + @SuppressLint("ClickableViewAccessibility") @Override public boolean onTouch(View v, MotionEvent event) { int action = event.getAction(); diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/richtext/WXRichTextView.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/richtext/WXRichTextView.java index 86f670ba6d..4605201c6b 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/component/richtext/WXRichTextView.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/richtext/WXRichTextView.java @@ -18,6 +18,7 @@ */ package com.taobao.weex.ui.component.richtext; +import android.annotation.SuppressLint; import android.content.Context; import android.graphics.drawable.Drawable; import android.text.Layout; @@ -37,6 +38,7 @@ public WXRichTextView(Context context) { super(context); } + @SuppressLint("ClickableViewAccessibility") @Override public boolean onTouchEvent(MotionEvent event) { boolean superResult = super.onTouchEvent(event); diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXCircleViewPager.java b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXCircleViewPager.java index 6c19615def..fc48fe45aa 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXCircleViewPager.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXCircleViewPager.java @@ -150,6 +150,7 @@ public boolean onInterceptTouchEvent(MotionEvent ev) { return false; } + @SuppressLint("ClickableViewAccessibility") @Override public boolean onTouchEvent(MotionEvent ev) { if(!scrollable) { diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXEditText.java b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXEditText.java index 5fa5dde0ba..3607c41f48 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXEditText.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXEditText.java @@ -67,6 +67,7 @@ public void setLines(int lines) { mLines = lines; } + @SuppressLint("ClickableViewAccessibility") @Override public boolean onTouchEvent(MotionEvent event) { boolean result = super.onTouchEvent(event); diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXHorizontalScrollView.java b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXHorizontalScrollView.java index 9f4cddea74..8ae842d599 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXHorizontalScrollView.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXHorizontalScrollView.java @@ -18,6 +18,7 @@ */ package com.taobao.weex.ui.view; +import android.annotation.SuppressLint; import android.content.Context; import android.graphics.Rect; import android.util.AttributeSet; @@ -105,6 +106,7 @@ public boolean dispatchTouchEvent(MotionEvent event) { return result; } + @SuppressLint("ClickableViewAccessibility") @Override public boolean onTouchEvent(MotionEvent ev) { if(!scrollable) { diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXImageView.java b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXImageView.java index efe946874e..5ef242f0b0 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXImageView.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXImageView.java @@ -23,20 +23,17 @@ import android.graphics.Bitmap; import android.graphics.drawable.BitmapDrawable; import android.graphics.drawable.Drawable; -import android.support.annotation.Keep; import android.support.annotation.NonNull; import android.support.annotation.Nullable; import android.view.MotionEvent; import android.view.View; import android.view.ViewGroup; import android.widget.ImageView; - import com.taobao.weex.ui.component.WXImage; import com.taobao.weex.ui.view.gesture.WXGesture; import com.taobao.weex.ui.view.gesture.WXGestureObservable; import com.taobao.weex.utils.ImageDrawable; import com.taobao.weex.utils.WXLogUtils; - import java.lang.ref.WeakReference; import java.util.Arrays; @@ -108,6 +105,7 @@ public WXGesture getGestureListener() { return wxGesture; } + @SuppressLint("ClickableViewAccessibility") @Override public boolean onTouchEvent(MotionEvent event) { boolean result = super.onTouchEvent(event); diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXScrollView.java b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXScrollView.java index ec6962141e..cc5b1c206a 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXScrollView.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXScrollView.java @@ -182,6 +182,7 @@ protected void dispatchDraw(Canvas canvas) { } } + @SuppressLint("ClickableViewAccessibility") @Override public boolean onTouchEvent(MotionEvent ev) { if(!scrollable) { diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXSwitchView.java b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXSwitchView.java index abba9f83fc..dd64e7a82c 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXSwitchView.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXSwitchView.java @@ -18,6 +18,7 @@ */ package com.taobao.weex.ui.view; +import android.annotation.SuppressLint; import android.content.Context; import android.support.v7.widget.SwitchCompat; import android.view.Gravity; @@ -46,6 +47,7 @@ public WXGesture getGestureListener() { return wxGesture; } + @SuppressLint("ClickableViewAccessibility") @Override public boolean onTouchEvent(MotionEvent event) { boolean result = super.onTouchEvent(event); diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXTextView.java b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXTextView.java index 314123c1ce..73a84c9973 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXTextView.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXTextView.java @@ -18,11 +18,11 @@ */ package com.taobao.weex.ui.view; +import android.annotation.SuppressLint; import android.content.ClipData; import android.content.ClipboardManager; import android.content.Context; import android.graphics.Canvas; -import android.graphics.Color; import android.support.annotation.ColorInt; import android.support.annotation.Nullable; import android.support.v7.widget.PopupMenu; @@ -31,11 +31,9 @@ import android.view.MenuItem; import android.view.MotionEvent; import android.view.View; - import com.taobao.weex.ui.component.WXText; import com.taobao.weex.ui.view.gesture.WXGesture; import com.taobao.weex.ui.view.gesture.WXGestureObservable; - import java.lang.ref.WeakReference; /** @@ -65,6 +63,7 @@ protected void onDraw(Canvas canvas) { canvas.restore(); } + @SuppressLint("ClickableViewAccessibility") @Override public boolean onTouchEvent(MotionEvent event) { boolean result = super.onTouchEvent(event); diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXVideoView.java b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXVideoView.java index 5abe2126ba..6b671cb8cc 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/view/WXVideoView.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/view/WXVideoView.java @@ -64,6 +64,7 @@ public void setOnVideoPauseListener(VideoPlayListener listener) { mVideoPauseListener = listener; } + @SuppressLint("ClickableViewAccessibility") @Override public boolean onTouchEvent(MotionEvent event) { boolean result = super.onTouchEvent(event); diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/view/gesture/WXGesture.java b/android/sdk/src/main/java/com/taobao/weex/ui/view/gesture/WXGesture.java index fecbb43a5b..6e88d67e97 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/view/gesture/WXGesture.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/view/gesture/WXGesture.java @@ -18,6 +18,10 @@ */ package com.taobao.weex.ui.view.gesture; +import static com.taobao.weex.common.Constants.Event.STOP_PROPAGATION; +import static com.taobao.weex.common.Constants.Event.STOP_PROPAGATION_RAX; + +import android.annotation.SuppressLint; import android.content.Context; import android.graphics.Point; import android.graphics.PointF; @@ -30,7 +34,6 @@ import android.view.View.OnTouchListener; import android.view.ViewGroup; import android.view.ViewParent; - import com.alibaba.fastjson.JSONArray; import com.alibaba.fastjson.JSONObject; import com.taobao.weex.bridge.EventResult; @@ -44,16 +47,12 @@ import com.taobao.weex.utils.WXLogUtils; import com.taobao.weex.utils.WXUtils; import com.taobao.weex.utils.WXViewUtils; - import java.util.ArrayList; import java.util.HashMap; import java.util.LinkedList; import java.util.List; import java.util.Map; -import static com.taobao.weex.common.Constants.Event.STOP_PROPAGATION; -import static com.taobao.weex.common.Constants.Event.STOP_PROPAGATION_RAX; - public class WXGesture extends GestureDetector.SimpleOnGestureListener implements OnTouchListener { private final static String TAG = "Gesture"; @@ -207,6 +206,7 @@ public boolean removeTouchListener(OnTouchListener listener) { return false; } + @SuppressLint("ClickableViewAccessibility") @Override public boolean onTouch(View v, MotionEvent event) { if(requestDisallowInterceptTouchEvent){ diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/WXRecyclerView.java b/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/WXRecyclerView.java index d29b7ae7d0..3f0d990b11 100644 --- a/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/WXRecyclerView.java +++ b/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/WXRecyclerView.java @@ -18,6 +18,7 @@ */ package com.taobao.weex.ui.view.listview; +import android.annotation.SuppressLint; import android.annotation.TargetApi; import android.content.Context; import android.os.Build; @@ -88,6 +89,7 @@ public WXGesture getGestureListener() { return mGesture; } + @SuppressLint("ClickableViewAccessibility") @Override public boolean onTouchEvent(MotionEvent event) { if(!scrollable) { diff --git a/android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java b/android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java index 463d1a678e..35a3086dbb 100644 --- a/android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java +++ b/android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java @@ -217,6 +217,7 @@ private static File _desSoCopyFile(String soName) { /** * copyStartUpSo */ + @SuppressLint("SdCardPath") public static void copyStartUpSo() { try { // copy libjsb.so to cache/weex/jsb/cputype @@ -402,6 +403,7 @@ static boolean checkSoIsValid(String libName, long size) { * @param version the version of the so library * @return the path of the so library */ + @SuppressLint("SdCardPath") static String _targetSoFile(String libName, int version) { Context context = mContext; if (null == context) {