Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Refactor the current AuditInfo related code and push the implementation to each catalog #317

Closed
Tracked by #250
jerryshao opened this issue Sep 4, 2023 · 0 comments · Fixed by #330
Closed
Tracked by #250

[Subtask] Refactor the current AuditInfo related code and push the implementation to each catalog #317

jerryshao opened this issue Sep 4, 2023 · 0 comments · Fixed by #330
Assignees
@jerryshao
Labels
subtask Subtasks of umbrella issue
Milestone
Graviton v0.2.0

Comments

@jerryshao
Copy link
Contributor

Describe the subtask

This issue tracks the work of refactoring the audit info related code, this issue mainly includes two things:

  1. Refactor the audit info related code to make all the fields optional.
  2. Push the implementation of audit info into each catalog, do not use a secondary to store the audit info.

Parent issue

#250
@jerryshao jerryshao added the subtask Subtasks of umbrella issue label Sep 4, 2023
@jerryshao jerryshao added this to the Graviton v0.2.0 milestone Sep 4, 2023
@jerryshao jerryshao self-assigned this Sep 4, 2023
This was referenced Sep 4, 2023
Closed
Closed
Merged
jerryshao added a commit that referenced this issue Sep 6, 2023
@jerryshao
[#317] feat(core, catalog): make fields in AuditInfo optional and ove…
d9dfd48 
…rwriteable (#330)

### What changes were proposed in this pull request?

This PR proposes to change the requirements of the `AuditInfo` fields to
make them optional and overwriteable.

### Why are the changes needed?

This is the first change of #250, the change is going to address two
problems:

1. If the `AuditInfo` is not existed in both Graviton store and
underlying source, we should support the empty `AuditInfo`, or only
several fields are set in `AuditInfo`.
2. If the `AuditInfo` are both set in the Graviton store and underlying
source, we should support `AuditInfo` mergeable.

Fix: #317

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Modify and add the UTs to test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerryshao jerryshao

Labels
subtask Subtasks of umbrella issue
Projects
None yet
Milestone
Graviton v0.2.0
1 participant
@jerryshao