From a1d86424cf87c306d1b47243d270eacf1fb2e1c3 Mon Sep 17 00:00:00 2001 From: vector Date: Thu, 2 Mar 2023 16:39:04 +0800 Subject: [PATCH] fix: throw error when render edge without terminal (#3331) --- packages/x6/package.json | 2 +- packages/x6/src/renderer/queueJob.ts | 6 +----- packages/x6/src/renderer/scheduler.ts | 10 +++++----- 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/packages/x6/package.json b/packages/x6/package.json index 000b037a93c..c93b0c57efa 100644 --- a/packages/x6/package.json +++ b/packages/x6/package.json @@ -1,6 +1,6 @@ { "name": "@antv/x6", - "version": "2.5.1", + "version": "2.6.1", "description": "JavaScript diagramming library that uses SVG and HTML for rendering", "main": "lib/index.js", "module": "es/index.js", diff --git a/packages/x6/src/renderer/queueJob.ts b/packages/x6/src/renderer/queueJob.ts index 8a8d58eec9c..2cdfb180366 100644 --- a/packages/x6/src/renderer/queueJob.ts +++ b/packages/x6/src/renderer/queueJob.ts @@ -46,11 +46,7 @@ export class JobQueue { let job while ((job = this.queue.shift())) { - try { - job.cb() - } catch (error) { - // pass - } + job.cb() if (this.getCurrentTime() - startTime >= this.frameInterval) { break } diff --git a/packages/x6/src/renderer/scheduler.ts b/packages/x6/src/renderer/scheduler.ts index eb29b09a820..7ac065c4cab 100644 --- a/packages/x6/src/renderer/scheduler.ts +++ b/packages/x6/src/renderer/scheduler.ts @@ -202,7 +202,7 @@ export class Scheduler extends Disposable { } let result = 0 - if (this.isInRenderArea(view)) { + if (this.isUpdateable(view)) { result = this.updateView(view, flag, options) viewItem.flag = result } else { @@ -479,11 +479,11 @@ export class Scheduler extends Disposable { return effectedEdges } - protected isInRenderArea(view: CellView) { - if (!this.renderArea) { - return true - } + protected isUpdateable(view: CellView) { if (view.isNodeView()) { + if (!this.renderArea) { + return true + } const node = view.cell return this.renderArea.isIntersectWithRect(node.getBBox()) }