From 3cc4bd6c2eff3126a11b93080d931306b0957fb0 Mon Sep 17 00:00:00 2001 From: Erwin Mombay Date: Mon, 13 Jan 2025 14:51:20 -0800 Subject: [PATCH 1/5] unskip carousel e2e tests --- .../0.1/test-e2e/test-arrows-non-looping.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js b/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js index 12ec711ea954..1e30efe0d6bc 100644 --- a/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js +++ b/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js @@ -31,21 +31,18 @@ describes.endtoend( nextArrow = await getNextArrow(controller); }); - // TODO(#40214): fix flaky test. - it.skip('should have the arrows in the correct initial state', async () => { + it('should have the arrows in the correct initial state', async () => { await expect(css(prevArrow, 'opacity')).to.equal('0'); await expect(css(nextArrow, 'opacity')).to.equal('1'); }); - // TODO(#40214): fix flaky test. - it.skip('should show the prev arrow when going to the first slide', async () => { + it('should show the prev arrow when going to the first slide', async () => { await controller.click(nextArrow); await expect(css(prevArrow, 'opacity')).to.equal('1'); await expect(css(nextArrow, 'opacity')).to.equal('1'); }); - // TODO(#40214): fix flaky test. - it.skip('should hide the next arrow when going to the end', async () => { + it('should hide the next arrow when going to the end', async () => { const el = await getScrollingElement(controller); await controller.scrollTo(el, {left: (SLIDE_COUNT - 1) * pageWidth}); From 69b6323a730c1de145129f9522ea216f0f704172 Mon Sep 17 00:00:00 2001 From: Erwin Mombay Date: Mon, 13 Jan 2025 15:48:37 -0800 Subject: [PATCH 2/5] remove failing tests on CI --- .../0.1/test-e2e/test-arrows-non-looping.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js b/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js index 1e30efe0d6bc..12ec711ea954 100644 --- a/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js +++ b/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js @@ -31,18 +31,21 @@ describes.endtoend( nextArrow = await getNextArrow(controller); }); - it('should have the arrows in the correct initial state', async () => { + // TODO(#40214): fix flaky test. + it.skip('should have the arrows in the correct initial state', async () => { await expect(css(prevArrow, 'opacity')).to.equal('0'); await expect(css(nextArrow, 'opacity')).to.equal('1'); }); - it('should show the prev arrow when going to the first slide', async () => { + // TODO(#40214): fix flaky test. + it.skip('should show the prev arrow when going to the first slide', async () => { await controller.click(nextArrow); await expect(css(prevArrow, 'opacity')).to.equal('1'); await expect(css(nextArrow, 'opacity')).to.equal('1'); }); - it('should hide the next arrow when going to the end', async () => { + // TODO(#40214): fix flaky test. + it.skip('should hide the next arrow when going to the end', async () => { const el = await getScrollingElement(controller); await controller.scrollTo(el, {left: (SLIDE_COUNT - 1) * pageWidth}); From 0780d765b30eadfe20a93a6e30de1119a1077371 Mon Sep 17 00:00:00 2001 From: Erwin Mombay Date: Tue, 14 Jan 2025 13:58:04 -0800 Subject: [PATCH 3/5] DO NOT SUBMIT --- .../amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js b/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js index 12ec711ea954..bbfdb89c29a7 100644 --- a/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js +++ b/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js @@ -32,7 +32,7 @@ describes.endtoend( }); // TODO(#40214): fix flaky test. - it.skip('should have the arrows in the correct initial state', async () => { + it('should have the arrows in the correct initial state', async () => { await expect(css(prevArrow, 'opacity')).to.equal('0'); await expect(css(nextArrow, 'opacity')).to.equal('1'); }); From 53841ce839c02679736493cfbc5306e35c5ec3ef Mon Sep 17 00:00:00 2001 From: Erwin Mombay Date: Tue, 14 Jan 2025 14:17:59 -0800 Subject: [PATCH 4/5] add another set again to see if it passes in CI --- build-system/tasks/e2e/selenium-webdriver-controller.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/build-system/tasks/e2e/selenium-webdriver-controller.js b/build-system/tasks/e2e/selenium-webdriver-controller.js index e6ca1a5aaa62..90771597ad8b 100644 --- a/build-system/tasks/e2e/selenium-webdriver-controller.js +++ b/build-system/tasks/e2e/selenium-webdriver-controller.js @@ -515,6 +515,14 @@ class SeleniumWebDriverController { ]); const resultWidth = Number(updatedHtmlElementSizes[0]); const resultHeight = Number(updatedHtmlElementSizes[1]); + + await this.driver + .manage() + .window() + .setRect({ + width: width + horizBorder, + height: height + vertBorder, + }); // TODO(sparhami) These are throwing errors, but are not causing the test // to fail immediately,.Figure out why, we want the test to fail here // instead of continuing. From 6d050dbfb6df2e14548996dd6e70200bbddb536e Mon Sep 17 00:00:00 2001 From: Erwin Mombay Date: Wed, 15 Jan 2025 15:12:10 -0800 Subject: [PATCH 5/5] force a single test on CI since it is passing locally --- .../amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js b/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js index bbfdb89c29a7..bd99270524ff 100644 --- a/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js +++ b/extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js @@ -32,7 +32,7 @@ describes.endtoend( }); // TODO(#40214): fix flaky test. - it('should have the arrows in the correct initial state', async () => { + it.only('should have the arrows in the correct initial state', async () => { await expect(css(prevArrow, 'opacity')).to.equal('0'); await expect(css(nextArrow, 'opacity')).to.equal('1'); });