Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov tolerance and notification time #3975

Closed
CasperWA opened this issue Apr 27, 2020 · 0 comments · Fixed by #3976
Closed

Update codecov tolerance and notification time #3975

CasperWA opened this issue Apr 27, 2020 · 0 comments · Fixed by #3976

Comments

@CasperWA
Copy link
Contributor

Unfortunately codecov is complaining, no idea why.

Is there a way that we can put a bigger tolerance to prevent these false positives? It is a bit annoying to have build officially fail just because a false positive in the coverage. Not only do PRs look like they are failing, even though everything is fine, but even when merging, it could mark the develop or master branch as failing, which will even influence the build status badge on the README in a negative way. Having a failing build status badge because of this is not the nicest. I have no experience with these coverage tools, so thought I'd ask before starting to investigate. @CasperWA do you have an idea?

Originally posted by @sphuber in #3957 (comment)

The coverage reporting should be a bit more friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant