Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markFeatureWriter improvement for Indic #28

Open
pauldhunt opened this issue Aug 2, 2024 · 0 comments
Open

markFeatureWriter improvement for Indic #28

pauldhunt opened this issue Aug 2, 2024 · 0 comments

Comments

@pauldhunt
Copy link
Contributor

When running markFeatureWriter with the options -m -t -c -i, on my Devanagari project it would be preferable for the Indic mark-to-mark lookup to be written at end of the abvm file, instead of to a separate mkmk file.

I believe that the -i and -m switches should do different things. Rules for Indic mark-to-mark should be written by default when the -i option is invoked to their respective abvm or blwm features. The -m switch should only apply to non-Indic mark-to-mark rules when they are both activated so that Indic and non-Indic mark-to-mark rules and lookups get written to the files that correspond with the correct mark features.

Running the markFeatureWriter in this case also produces empty mark.fea files. This should not happen.

Lastly, a sample of the output to the mkmk file when run as described is as follows:

lookup MKMK_MARK_abvmBNDU {
 	lookupflag MarkAttachmentType @MC_abvmBNDU;

	pos mark dvEsign <anchor -53 683> mark @MC_abvmBNDU;
	pos mark dvAisign <anchor 2 683> mark @MC_abvmBNDU;
	pos mark dvEcandrasign <anchor -149 734> mark @MC_abvmBNDU;
	pos mark dvEshortsign <anchor -9 683> mark @MC_abvmBNDU;
	pos mark dvAysign <anchor 1 683> mark @MC_abvmBNDU;
} MKMK_MARK_abvmBNDU;

the line lookupflag MarkAttachmentType @MC_abvmBNDU; actually prevents the following rules from forming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant