You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have discussed here the utility of the release branch.
We agreed to continue the discussion outside the PR since it was not strictly related.
From my point of view, these are the pros for a release branch:
docs webpage will only be updated when there's a new release
to get around docs showing unreleased features, we can just make the docs versioned which is probably a good idea either way
it's easier to do hotfix releases
main should be deployable at all times, so it should always be possible to create a new release from main - including hotfix
it is still possible to create a hotfix release from a different branch if such a need arises (but most of the times, it shouldn't)
There are also drawbacks:
it makes the repository and release process a little bit more complex
there's a possibility of release branch and main getting out of sync and we'd have to do cherry-picks - not that likely and difficult to fix but something to keep in mind
it deviates from what our other opensource repositories are doing (afaik)
In general, I don't really see clear benefits to having a release branch and I would rather keep the setup simple and closer to how things are done at Shopify and in opensource as a whole.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
We have discussed here the utility of the release branch.
We agreed to continue the discussion outside the PR since it was not strictly related.
From my point of view, these are the pros for a release branch:
main
should be deployable at all times, so it should always be possible to create a new release frommain
- including hotfixThere are also drawbacks:
release
branch andmain
getting out of sync and we'd have to do cherry-picks - not that likely and difficult to fix but something to keep in mindIn general, I don't really see clear benefits to having a
release
branch and I would rather keep the setup simple and closer to how things are done at Shopify and in opensource as a whole.Beta Was this translation helpful? Give feedback.
All reactions