Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid prop as supplied to MenuItem when using a custom component. #3138

Closed
tomitrescak opened this issue Sep 8, 2018 · 1 comment
Closed

Invalid prop as supplied to MenuItem when using a custom component. #3138

tomitrescak opened this issue Sep 8, 2018 · 1 comment
Labels
bug

Comments

@tomitrescak
Copy link
Contributor

Bug Report

Hi, previously I could specify the "as" property to MenuItem as a custom component. This is a key functionality if I want to use custom Link components, such as those from React router or Reach Router.

Version

0.82.3

Testcase

Here you go (check out the console):

https://codesandbox.io/s/q71qy7kw6q
tomitrescak added a commit to tomitrescak/Semantic-UI-React that referenced this issue Sep 8, 2018
@tomitrescak
Allows having JSX elements as an "as" property
d33ce51 
See Semantic-Org#3138 for the problem described. 
Solves problem when custom links are used
@tomitrescak tomitrescak mentioned this issue Sep 8, 2018
Merged
layershifter pushed a commit that referenced this issue Sep 10, 2018
@tomitrescak @layershifter
fix(customPropTypes): allow to pass an object to "as" (#3139)
9d36af3 
* Allows having JSX elements as an "as" property

See #3138 for the problem described. 
Solves problem when custom links are used

* update order
@layershifter
Copy link
Member

Fixed in #3139.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomitrescak @layershifter