Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace manually constructed keys with factory keys #1533

Closed
levithomason opened this issue Mar 30, 2017 · 2 comments
Closed

Replace manually constructed keys with factory keys #1533

levithomason opened this issue Mar 30, 2017 · 2 comments
Labels
Milestone

Comments

@levithomason
Copy link
Member

We currently have several components that build up a key, finalKey, etc. All factories now support generating keys from string and number shorthand. If a user passes an object or an element, they must define their own key.

We need to remove all manual build up of keys and leave this to factories and users only.

@stale
Copy link

stale bot commented Feb 4, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 4, 2018
@levithomason
Copy link
Member Author

See #2424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant