Append To combo box only has one graph option for Theory data

[smk78]

Describe the bug
When you have multiple datasets in the Data Explorer you have the option to select one or more and Create [a] New graph, or to Append [them] To an existing graph.

It seems that the second of these two actions is only available to Data data and not Theory data.

To Reproduce
Steps to reproduce the behavior:

1. Run SasView
2. Create a FitPage and select any model. Calculate the model and then Compute/Plot the calculation.
3. Now create a second FitPage and repeat the process.

This creates a couple of Theory datasets and a graph of each calculation.

4. Now select one or other of the Theory datasets and try Append To the graph with the other dataset (ie, to put both datasets on the same graph).

There is only one graph option in the combo box.

Expected behavior
All of the generated graphs should be available in the combo box.

SasView version (please complete the following information):

• Version: release 5.0.5, but affects all 5.x.

Operating system (please complete the following information):

• OS: W10/x64

Additional context
The expected behaviour is available in 4.2.2. This issue was introduced in 5.x.

[rozyczko]

Just did this with 5.0.5 and got the second theory plot correctly appended.
It would be good to see what is different between what we both did

[smk78]

@rozyczko , sorry for the delay in picking this up. But did you do that in the release version or your dev version?

I've just uninstalled release 5.0.5, re-downloaded & re-installed it, and I can re-create this issue at will.

[butlerpd]

Looking at the examples ...I'm guessing that @rozyczko tried to append M2 to graph 1? That does work for me too. The problem is that if you cannot append M1 to Graph 2. In fact you cannot append anything to anything except graph 1. At least in my test of 5.0.5. Not sure if that helps?

[smk78]

Yes, that's my point (arguably expressed better)! You can create as many plots as you like but you can only append a Theory to Graph1 in 5.x. Thanks, @butlerpd .

[rozyczko]

Ah! yes, I can reproduce the problem now. So the bug is in the content of the plot combobox when theory plots are generated.
Thanks for pointing this out, @butlerpd

[rozyczko]

Addressed by #2298

[lucas-wilkins]

This appears to have been merged. Just forgot to close the issue.