Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal docs for complex number support #628

Merged
merged 6 commits into from
Feb 25, 2025
Merged

Conversation

pkienzle
Copy link
Contributor

@pkienzle pkienzle commented Jan 21, 2025

Fixes #589

Also updates docs to mention sasmodels.special for python models since that also touches plugin.rst. Fixes #579.

@krzywon krzywon changed the base branch from master to release_1.0.9 January 22, 2025 19:41
@butlerpd butlerpd self-requested a review January 28, 2025 14:42
Copy link
Member

@butlerpd butlerpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is certainly minimalistic but also certainly better than what we had. The doc compile ok and links work. I have not verified the accuracy of each of these functions however. Given the utility of having this information available and the impeding code freeze I recommend merging as is... though I do not love the way the link to special functions for c models is added (see inline comment)

@krzywon
Copy link
Collaborator

krzywon commented Feb 25, 2025

I will check with @pkienzle to see if the suggestion by @butlerpd could be easily implemented before merging.

@krzywon krzywon merged commit f90f36d into release_1.0.9 Feb 25, 2025
18 checks passed
@krzywon krzywon deleted the 589_complex_numbers branch February 25, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants