Changes in #563 break SasView main

[lucas-wilkins]

The changes in #563 have caused some issues with DirectModel as it used in SasView (and probably peoples scripts).

The text of #563 says its only an error that will occur outside of SasView and just requires different parameter names, but SasView is affected. Whilst changing the names does remove the error, it results in calculations that are incorrect (in parallelepiped at least, a -> length_a etc).

[lucas-wilkins]

The bug is back.

[pkienzle]

Having an incorrect parameter name in a call (e.g., a rather than length_a) will cause the correct parameter name to assume the default value and ignore the incorrect parameter value.

Checking for unused parameters protects us from typos in the call. It seems strictly better to catch these errors rather than unexpectedly using the default values.

What are the cases where parameters are being passed that should not be used? Can the problem be addressed in that code instead?

[pkienzle]

Orientation viewer in sasview seems to function even with the check enabled.

Can we close this ticket? Or are there other cases where things are breaking?