From fd61df4cd3c118efbed0a7f12ff1012ce6720e9d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alexander=20D=C3=BCmont?= <alexander_duemont@web.de>
Date: Fri, 18 Oct 2024 12:36:39 +0200
Subject: [PATCH 1/4] Fix plugins path root declarations; Make PMD run by
 default

---
 pom.xml | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/pom.xml b/pom.xml
index e09c50d42..4b53c172b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -396,9 +396,9 @@
         <artifactId>maven-checkstyle-plugin</artifactId>
         <version>3.5.0</version>
         <configuration>
-          <configLocation>.pipeline/checkstyle.xml</configLocation>
+          <configLocation>${project.rootdir}/.pipeline/checkstyle.xml</configLocation>
           <!-- Exclude generated clients -->
-          <suppressionsLocation>.pipeline/checkstyle-suppressions.xml</suppressionsLocation>
+          <suppressionsLocation>${project.rootdir}/.pipeline/checkstyle-suppressions.xml</suppressionsLocation>
           <linkXRef>false</linkXRef>
         </configuration>
         <dependencies>
@@ -413,13 +413,20 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-pmd-plugin</artifactId>
         <version>3.25.0</version>
+        <executions>
+          <execution>
+            <phase>verify</phase>
+            <goals>
+              <goal>check</goal>
+            </goals>
+          </execution>
+        </executions>
         <configuration>
           <rulesets>
-            <ruleset>.pipeline/pmd.xml</ruleset>
-            <ruleset>.pipeline/sdk_specific_pmd_rules.xml</ruleset>
+            <ruleset>${project.rootdir}/.pipeline/pmd.xml</ruleset>
+            <ruleset>${project.rootdir}/.pipeline/sdk_specific_pmd_rules.xml</ruleset>
             <!-- content of the PMD default rule set for Java can be found here:
 https://gitbox.apache.org/repos/asf?p=maven-pmd-plugin.git;a=blob_plain;f=src/main/resources/rulesets/java/maven-pmd-plugin-default.xml;hb=HEAD -->
-            <ruleset>/rulesets/java/maven-pmd-plugin-default.xml</ruleset>
           </rulesets>
           <linkXRef>false</linkXRef>
           <targetJdk>${maven.compiler.release}</targetJdk>
@@ -435,9 +442,9 @@ https://gitbox.apache.org/repos/asf?p=maven-pmd-plugin.git;a=blob_plain;f=src/ma
         <artifactId>spotbugs-maven-plugin</artifactId>
         <version>4.8.6.4</version>
         <configuration>
-          <includeFilterFile>.pipeline/spotbugs.xml</includeFilterFile>
+          <includeFilterFile>${project.rootdir}/.pipeline/spotbugs.xml</includeFilterFile>
           <!-- Exclude generated clients -->
-          <excludeFilterFile>.pipeline/spotbugs-exclusions.xml</excludeFilterFile>
+          <excludeFilterFile>${project.rootdir}/.pipeline/spotbugs-exclusions.xml</excludeFilterFile>
           <effort>Max</effort>
           <threshold>Low</threshold>
           <maxHeap>2048</maxHeap>

From 3ad86da0a3c0fcdaeee35df3979a16ec4b183bce Mon Sep 17 00:00:00 2001
From: SAP Cloud SDK Bot <cloudsdk@sap.com>
Date: Fri, 18 Oct 2024 10:39:12 +0000
Subject: [PATCH 2/4] Formatting

---
 pom.xml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/pom.xml b/pom.xml
index 4b53c172b..3a34d47c0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -413,14 +413,6 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-pmd-plugin</artifactId>
         <version>3.25.0</version>
-        <executions>
-          <execution>
-            <phase>verify</phase>
-            <goals>
-              <goal>check</goal>
-            </goals>
-          </execution>
-        </executions>
         <configuration>
           <rulesets>
             <ruleset>${project.rootdir}/.pipeline/pmd.xml</ruleset>
@@ -436,6 +428,14 @@ https://gitbox.apache.org/repos/asf?p=maven-pmd-plugin.git;a=blob_plain;f=src/ma
             <exclude>com/sap/ai/sdk/orchestration/client/**/*</exclude>
           </excludes>
         </configuration>
+        <executions>
+          <execution>
+            <goals>
+              <goal>check</goal>
+            </goals>
+            <phase>verify</phase>
+          </execution>
+        </executions>
       </plugin>
       <plugin>
         <groupId>com.github.spotbugs</groupId>

From df571e7bc2b1a8763cc797bf659bac20e5cafd49 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alexander=20D=C3=BCmont?= <alexander_duemont@web.de>
Date: Fri, 18 Oct 2024 12:47:11 +0200
Subject: [PATCH 3/4] Print errors to console

---
 pom.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pom.xml b/pom.xml
index 4b53c172b..31074fd5c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -430,6 +430,7 @@ https://gitbox.apache.org/repos/asf?p=maven-pmd-plugin.git;a=blob_plain;f=src/ma
           </rulesets>
           <linkXRef>false</linkXRef>
           <targetJdk>${maven.compiler.release}</targetJdk>
+          <printFailingErrors>true</printFailingErrors>
           <excludes>
             <!-- Exclude generated clients -->
             <exclude>com/sap/ai/sdk/core/client/**/*</exclude>

From 578379dba8f0c391fe771efc6d89db152142feaa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alexander=20D=C3=BCmont?=
 <22489773+newtork@users.noreply.github.com>
Date: Mon, 21 Oct 2024 11:37:16 +0200
Subject: [PATCH 4/4] Remove unrelated change

---
 pom.xml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/pom.xml b/pom.xml
index 87d3c9a9e..32cee0669 100644
--- a/pom.xml
+++ b/pom.xml
@@ -396,9 +396,9 @@
         <artifactId>maven-checkstyle-plugin</artifactId>
         <version>3.5.0</version>
         <configuration>
-          <configLocation>${project.rootdir}/.pipeline/checkstyle.xml</configLocation>
+          <configLocation>.pipeline/checkstyle.xml</configLocation>
           <!-- Exclude generated clients -->
-          <suppressionsLocation>${project.rootdir}/.pipeline/checkstyle-suppressions.xml</suppressionsLocation>
+          <suppressionsLocation>.pipeline/checkstyle-suppressions.xml</suppressionsLocation>
           <linkXRef>false</linkXRef>
         </configuration>
         <dependencies>
@@ -443,9 +443,9 @@ https://gitbox.apache.org/repos/asf?p=maven-pmd-plugin.git;a=blob_plain;f=src/ma
         <artifactId>spotbugs-maven-plugin</artifactId>
         <version>4.8.6.4</version>
         <configuration>
-          <includeFilterFile>${project.rootdir}/.pipeline/spotbugs.xml</includeFilterFile>
+          <includeFilterFile>.pipeline/spotbugs.xml</includeFilterFile>
           <!-- Exclude generated clients -->
-          <excludeFilterFile>${project.rootdir}/.pipeline/spotbugs-exclusions.xml</excludeFilterFile>
+          <excludeFilterFile>.pipeline/spotbugs-exclusions.xml</excludeFilterFile>
           <effort>Max</effort>
           <threshold>Low</threshold>
           <maxHeap>2048</maxHeap>