-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stylelint for scss files #587
Comments
Some strategies to prevent UI break.
|
@mikeghen Hi mike, I have found a lot of stylelint format problems, and I have made a lot of file modifications, such as those shown in the img, but the project cannot run. I think the difficulty of this problem is very high, so I want to ask this question, how much bounty can i get? |
@um1ng Changing stuff to kebab-case and adding spaces doesn't seem like a very hard problem , can't most of these automatically be handled with a simple command? |
Codemod needs some knowledge of AST, but not everyone knows that, including me. I think the style lint affects many |
I'm all for formatting so let me know when something's ready here |
Yeah, I am ready do these tasks. |
@um1ng If yes, you can submit a PR, and @mikeghen will put a bounty then, like this issue: #584 (comment) (Task was finished and Mike put $1000 bounty on it, for example) |
Okay, I'll do it as soon as possible. |
@mikeghen If no one is doing this, I can pick it up this weekend. |
@Himnashu, go ahead, lmk how it goes |
Any progrss on this? |
@Seroxdesign take this on. |
Solution:
https://stylelint.io/user-guide/get-started/#linting-everything-else
stylelint-scss/stylelint-config-standard-scss#5 (comment)
Criteria:
stylelint
,pre-commit
hook callsnpx stylelint "**/*.scss"
.Note: this blocks the Nextjs migration because of some strange syntax in our
.scss
file.The text was updated successfully, but these errors were encountered: