Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old docs are not available to view on the documentation site #55

Closed
RebeccaStevens opened this issue Aug 10, 2023 · 0 comments
Closed

Old docs are not available to view on the documentation site #55

RebeccaStevens opened this issue Aug 10, 2023 · 0 comments
Labels
Type: Documentation Solely about the documentation of the project.

Comments

@RebeccaStevens
Copy link
Owner

This part of the workflow is trying to download the old docs from the gh-pages branch, but there is not such branch:

uom-types/.github/workflows/release-docs.yml

Lines 20 to 24 in 25c65b9

- name: get the gh-pages repo
uses: actions/checkout@v3
with:
ref: gh-pages
continue-on-error: true

Based on actions/upload-pages-artifact#57 the easiest solution would probably be to just use a gh-pages branch.
@RebeccaStevens RebeccaStevens added the Type: Documentation Solely about the documentation of the project. label Aug 10, 2023
RebeccaStevens added a commit that referenced this issue Aug 12, 2023
@RebeccaStevens
ci: update release-docs workflow
d962c08 
fix #55
RebeccaStevens added a commit that referenced this issue Aug 12, 2023
@RebeccaStevens
ci: update release-docs workflow
d53eb8e 
fix #55
RebeccaStevens added a commit that referenced this issue Aug 12, 2023
@RebeccaStevens
ci: update release-docs workflow
52001e4 
fix #55
RebeccaStevens added a commit that referenced this issue Aug 12, 2023
@RebeccaStevens
ci: update release-docs workflow
a859cb2 
fix #55
@RebeccaStevens RebeccaStevens mentioned this issue Aug 12, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit to JoshuaKGoldberg/ts-api-utils that referenced this issue Dec 24, 2023
@RebeccaStevens @JoshuaKGoldberg
ci: improve the release docs workflow (#254)
9e79406 
<!-- 👋 Hi, thanks for sending a PR to ts-api-utils! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #191
- [x] That issue was marked as [`status: accepting
prs`](/~https://github.com/JoshuaKGoldberg/ts-api-utils/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](/~https://github.com/JoshuaKGoldberg/ts-api-utils/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

The same issue as RebeccaStevens/uom-types#55

## Before Merge

`gh-pages` branch need to be created. Create with: 

```sh
git switch --orphan gh-pages
git commit --allow-empty -m "initial docs" --no-verify
git push
```

---------

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Documentation Solely about the documentation of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RebeccaStevens