Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash-completion package missing from Fedora template #8394

Closed
jamke opened this issue Aug 6, 2023 · 9 comments
Closed

bash-completion package missing from Fedora template #8394

jamke opened this issue Aug 6, 2023 · 9 comments
Labels
affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. C: Fedora P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. R: duplicate Resolution: Another issue exists that is very similar to or subsumes this one.

Comments

@jamke
Copy link

jamke commented Aug 6, 2023

How to file a helpful issue

Qubes OS release

R4.0, R4.1, R4.2 (probably)

Brief summary

The latest fedora-38 template is still missing bash-completion package. Debian-11 still has it, Fedora does not.
sudo dnf install ox<TAB> produces nothing in any terminal on fedora-38 template unlike real Fedora-38 where is works.

Bash completion is present not only in Fedora for ages and is present in ALL GNU/Linux distros.
Debian and debian-based Qubes OS templates have bash-completion installed, too.
The problem exists in Qubes OS for so long that it is starting to be ridiculous.

Steps to reproduce

Open terminal inside fedora-38 template.
Try to install something with shell completion:
sudo dnf install <TAB><TAB>

Expected behavior

The list of packages is provided, completion works as in the original Fedora-38.

Actual behavior

Nothing happens or the file of local files provided. Completion is broken.

Solution:

Add bash-completion package to the fedora templates as it presents in the original Fedora for ages.

P.S. dom0 also reserves to have a working completion, also has no package installed.

@jamke jamke added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug labels Aug 6, 2023
@andrewdavidwong andrewdavidwong added C: Fedora needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Aug 7, 2023
@andrewdavidwong andrewdavidwong added this to the Release 4.1 updates milestone Aug 7, 2023
@andrewdavidwong andrewdavidwong changed the title The latest fedora-38 template is still missing bash completion unlike debian-11 bash-completion package missing from Fedora template Aug 7, 2023
@andrewdavidwong andrewdavidwong added the affects-4.1 This issue affects Qubes OS 4.1. label Aug 8, 2023
@andrewdavidwong andrewdavidwong removed this from the Release 4.1 updates milestone Aug 13, 2023
@jamke
Copy link
Author

jamke commented Dec 21, 2023

Affects R4.2?

@jamke
Copy link
Author

jamke commented Jan 20, 2024

affects R4.2?

@andrewdavidwong andrewdavidwong added the affects-4.2 This issue affects Qubes OS 4.2. label Jan 20, 2024
@jamke
Copy link
Author

jamke commented Feb 24, 2025

I have this problem on R4.3.4.

To check: open terminal in sys-firewall, type dnf and press tab twice. Nothing happens, but should.

@andrewdavidwong andrewdavidwong added the affects-4.3 This issue affects Qubes OS 4.3. label Feb 24, 2025
@jamke
Copy link
Author

jamke commented Feb 25, 2025

@andrewdavidwong sorry for typo, I meant R4.2.4, not R4.3.4.

@alimirjamali
Copy link

Add bash-completion package to the fedora templates as it presents in the original Fedora for ages.

Ok. the decision for this is simple and fast forward. Either we add it or not. Either to qubes-core-agent (my preference) or maybe to qubes-vm-recommended. Only one line

@marmarek add it or close the ticket?

@unman
Copy link
Member

unman commented Feb 25, 2025 via email

@alimirjamali
Copy link

alimirjamali commented Feb 25, 2025

At one time #7879 covered Fedora templates as well as dom0, so strictly
this is duplicate of that.

The above is correct. I believe this issue could be closed in favour of the issue Unman linked since that one has better technical details and discussions.

The title of the latter issue could be corrected to "bash completion package missing in dom0 and Fedora templates"

@unman
Copy link
Member

unman commented Feb 25, 2025 via email

@andrewdavidwong andrewdavidwong added R: duplicate Resolution: Another issue exists that is very similar to or subsumes this one. and removed affects-4.3 This issue affects Qubes OS 4.3. needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Feb 25, 2025
Copy link

This issue has been closed as a "duplicate." This means that another issue exists that is very similar to or subsumes this one. If any useful information on this issue is not already present on the other issue, please add it in a comment on the other issue. Here are some common cases of duplicate issues:

  • The other issue is closed. The other issue being closed does not prevent this issue from duplicating it. We will examine the closed issue and, if appropriate, reopen it.
  • The other issue is for a different Qubes release. We usually maintain only one issue for all affected Qubes releases.
  • The other issue is very old. The mere age of an issue is not, by itself, a relevant factor when determining duplicates.

By default, the newer issue will be closed in favor of the older issue. However, we make exceptions when we determine that it would be significantly more useful to keep the newer issue open instead of the older one.

We respect the time and effort you have taken to file this issue, and we understand that this outcome may be unsatisfying. Please accept our sincere apologies and know that we greatly value your participation and membership in the Qubes community.

If anyone reading this believes that this issue was closed in error or that the resolution of "duplicate" is not accurate, please leave a comment below saying so, and we will review this issue again. For more information, see How issues get closed.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. C: Fedora P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. R: duplicate Resolution: Another issue exists that is very similar to or subsumes this one.
Projects
None yet
Development

No branches or pull requests

4 participants