Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error downloading custom class plugin #1136

Closed
garretwilson opened this issue May 12, 2017 · 10 comments
Closed

Error downloading custom class plugin #1136

garretwilson opened this issue May 12, 2017 · 10 comments

Comments

@garretwilson
Copy link

I tried to download Prism with the "coy" theme, all languages, and the following plugins:

  • Line Numbers
  • Custom Class
  • Keep Markup
  • Command Line

The web pages displayed the following error:

An error occurred while fetching the file "plugins/custom-class/prism-custom-class.css".

@LeaVerou
Copy link
Member

That probably happens because the Custom Class plugin doesn't come with any CSS. Is there any actual issue?

@garretwilson
Copy link
Author

I haven't tried it yet --- I assumed a big error message meant that there was an error. I didn't want to waste my time when the site clearly told me that something was wrong.

@LeaVerou
Copy link
Member

Technically, the site told you nothing. It's not the site's fault you were peeking at the console. AFAIK there's actually no way to client-side check if a file exists without a 404 showing up in the console.
So, as long as there's no actual issue, I'm closing this. Feel free to reopen if there is!

@garretwilson
Copy link
Author

Er, @LeaVerou, I'm not talking about the console. I'm talking about HTML message right there on the page.

Did you try to reproduce this?

@garretwilson
Copy link
Author

prism-issue-1136

@garretwilson
Copy link
Author

Feel free to reopen if there is!

I don't seem to have permissions on this project to reopen this issue. But don't you agree that the message above sure looks like there was a real error, and that something went wrong?

@garretwilson
Copy link
Author

Technically, the site told you nothing.

Technically... I need to drink some tequila. It's been a long, frustrating day. But I'm going to bed and save the tequila for tomorrow. Good night.

@zeitgeist87
Copy link
Collaborator

It should be fixed with ba64f8d. The property noCSS: true was missing for the Custom Class plugin in components.js. By default the downloader assumes, that there is a CSS file.

@LeaVerou LeaVerou reopened this May 13, 2017
@LeaVerou
Copy link
Member

Yeah, sorry for the misunderstanding, this does look like a bug. Probably a bug with the site though, not with your bundle, so still try downloading, I bet there won't be any issue.

@garretwilson
Copy link
Author

Thanks @zeitgeist87 and @LeaVerou; it seems I was able download the custom class plugin.

But the plugin seems completely broken; see #1137.

Please, could someone go to #1055 (comment) and tell me why I have to go through this whole rigmarole in the first place? Why can't Prism simply prefix all its classes with something (anything!) by default, to avoid intercepting my own classes?

@Golmote Golmote closed this as completed Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants